summaryrefslogtreecommitdiff
path: root/common/cli_simple.c
diff options
context:
space:
mode:
authorPeng Fan <van.freenix@gmail.com>2016-01-10 13:01:22 +0800
committerTom Rini <trini@konsulko.com>2016-01-13 21:05:26 -0500
commitbb08a6e7d513cc1f591b35a6e7e68dd92078eed6 (patch)
tree0c371a994d4777794366f92d25c5673ad1e3dcac /common/cli_simple.c
parent247be79a99041e0b5f56cea4100f5cc98e827b64 (diff)
downloadu-boot-bb08a6e7d513cc1f591b35a6e7e68dd92078eed6.tar.gz
common: cli_simple: use strlcpy instead of strcpy
Report Coverity log: Destination buffer too small (STRING_OVERFLOW) string_overflow: You might overrun the 1024 byte destination string lastcommand by writing 1025 bytes from console_buffer Signed-off-by: Peng Fan <van.freenix@gmail.com> Cc: Heiko Schocher <hs@denx.de> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'common/cli_simple.c')
-rw-r--r--common/cli_simple.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/common/cli_simple.c b/common/cli_simple.c
index 9c3d073d58..bb96aaead6 100644
--- a/common/cli_simple.c
+++ b/common/cli_simple.c
@@ -276,7 +276,8 @@ void cli_simple_loop(void)
flag = 0; /* assume no special flags for now */
if (len > 0)
- strcpy(lastcommand, console_buffer);
+ strlcpy(lastcommand, console_buffer,
+ CONFIG_SYS_CBSIZE + 1);
else if (len == 0)
flag |= CMD_FLAG_REPEAT;
#ifdef CONFIG_BOOT_RETRY_TIME