diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2021-01-11 08:46:58 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2021-01-27 17:03:16 -0500 |
| commit | 76c78a548144b69ecc3ed9cc2d670297983da6b1 (patch) | |
| tree | 1b58c8cd5769413963bde5ffea09b9b692ac3f30 /common | |
| parent | b7cfe32e186d453001a12ee0ee2c85d08a0ecd53 (diff) | |
| download | u-boot-76c78a548144b69ecc3ed9cc2d670297983da6b1.tar.gz | |
common: fit-sig: Fix error message in fit_config_verify_sig()
In fit_config_verify_sig(), when no 'signature*' subnode exists in
the configuration node, the fdt_for_each_subnode() loop is a no-op.
Therefore, no error flags are set, and 'err_,sg' is not populated
with an error string. This is incorrect behavior.
Populate err_msg to indicate that no 'signature' is found, before
entering the loop. The first call to fit_image_verify_sig() will
override clear err_msg, or set it to a more specific message.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/image-fit-sig.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/image-fit-sig.c b/common/image-fit-sig.c index d39741e905..31cc580941 100644 --- a/common/image-fit-sig.c +++ b/common/image-fit-sig.c @@ -360,7 +360,7 @@ static int fit_config_verify_sig(const void *fit, int conf_noffset, const void *sig_blob, int sig_offset) { int noffset; - char *err_msg = ""; + char *err_msg = "No 'signature' subnode found"; int verified = 0; int ret; |