diff options
| author | Simon Glass <sjg@chromium.org> | 2019-09-25 08:55:47 -0600 |
|---|---|---|
| committer | Bin Meng <bmeng.cn@gmail.com> | 2019-10-08 13:57:37 +0800 |
| commit | c8b31cce45477dea51b3c65b2c0e12ea9cced9f0 (patch) | |
| tree | 45ebb133b861267c2c98062d1dc7970d8cb7185c /drivers/core/uclass.c | |
| parent | d3e773613b6d159204de4894a4e0d191717ce318 (diff) | |
| download | u-boot-c8b31cce45477dea51b3c65b2c0e12ea9cced9f0.tar.gz | |
dm: core: Drop a few early returns
Two functions in this file return early for no good reason. Adjust the
code to match the standard DM style of returning 0 at the end of the
function on success.
Oddly enough this save 12 bytes of code size on ARM.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Diffstat (limited to 'drivers/core/uclass.c')
| -rw-r--r-- | drivers/core/uclass.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index b33296542f..af575bbeb7 100644 --- a/drivers/core/uclass.c +++ b/drivers/core/uclass.c @@ -714,8 +714,11 @@ int uclass_pre_probe_device(struct udevice *dev) if (!dev->parent) return 0; uc_drv = dev->parent->uclass->uc_drv; - if (uc_drv->child_pre_probe) - return uc_drv->child_pre_probe(dev); + if (uc_drv->child_pre_probe) { + ret = uc_drv->child_pre_probe(dev); + if (ret) + return ret; + } return 0; } @@ -735,8 +738,11 @@ int uclass_post_probe_device(struct udevice *dev) } uc_drv = dev->uclass->uc_drv; - if (uc_drv->post_probe) - return uc_drv->post_probe(dev); + if (uc_drv->post_probe) { + ret = uc_drv->post_probe(dev); + if (ret) + return ret; + } return 0; } |