diff options
| author | Simon Glass <sjg@chromium.org> | 2018-06-12 00:05:01 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2018-06-19 07:31:44 -0400 |
| commit | fb95283931011aef78d885f2799ad9d7367f4e48 (patch) | |
| tree | 37b3d2f8be779022f3bc6ed28ce6feb7ebdfb2f7 /drivers/mtd/spi | |
| parent | 8a682e03d7d18b3d20810ea83fcec69f8d09c909 (diff) | |
| download | u-boot-fb95283931011aef78d885f2799ad9d7367f4e48.tar.gz | |
spi: sandbox: Fix memory leak in sandbox_sf_bind_emul()
Move the strdup() call so that it is only done when we know we will bind
the device.
Reported-by: Coverity (CID: 131216)
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/mtd/spi')
| -rw-r--r-- | drivers/mtd/spi/sandbox.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/mtd/spi/sandbox.c b/drivers/mtd/spi/sandbox.c index 7893efee12..f23c0e13e0 100644 --- a/drivers/mtd/spi/sandbox.c +++ b/drivers/mtd/spi/sandbox.c @@ -567,16 +567,17 @@ int sandbox_sf_bind_emul(struct sandbox_state *state, int busnum, int cs, strncpy(name, spec, sizeof(name) - 6); name[sizeof(name) - 6] = '\0'; strcat(name, "-emul"); - str = strdup(name); - if (!str) - return -ENOMEM; drv = lists_driver_lookup_name("sandbox_sf_emul"); if (!drv) { puts("Cannot find sandbox_sf_emul driver\n"); return -ENOENT; } + str = strdup(name); + if (!str) + return -ENOMEM; ret = device_bind(bus, drv, str, NULL, of_offset, &emul); if (ret) { + free(str); printf("Cannot create emul device for spec '%s' (err=%d)\n", spec, ret); return ret; |