summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorAndre Przywara <andre.przywara@arm.com>2019-11-23 17:58:59 +0000
committerJoe Hershberger <joe.hershberger@ni.com>2019-12-09 09:47:43 -0600
commit16cdc2daa07986243751a9f545aa287c60e04ced (patch)
tree4110d7cd6d055abe517675fbbf59b42e61c5839d /net
parente22e3aff923937add30f7f800197c9f5713ea611 (diff)
downloadu-boot-16cdc2daa07986243751a9f545aa287c60e04ced.tar.gz
net: tftp: Fix too small block size
Commit b618b3707633 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig") accidentally set the default *option* TFTP block size to 512 bytes, even though the comment in the code says that this is a terrible choice. Most boards didn't define the symbol before, so they got the default block size of 1468 bytes before, but now use 512 bytes, which is also the fallback. This leads to both abysmal performance and a lot of hashes printed on the screen (one character for every 5K), which is both annoying and slow over serial links. Set the default block size in Kconfig back to the value it had before. This improves TFTP performance from 2.8 MB/s to 6.9 MB/s on a Pine64. Fixes: b618b3707633 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig") Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Diffstat (limited to 'net')
-rw-r--r--net/Kconfig2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/Kconfig b/net/Kconfig
index 68cecf75a2..a07f6746c5 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -31,7 +31,7 @@ config IP_DEFRAG
config TFTP_BLOCKSIZE
int "TFTP block size"
- default 512
+ default 1468
help
Default TFTP block size.