From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- arch/arm/include/asm/arch-mx27/mxcmmc.h | 2 +- arch/arm/include/asm/arch-mx31/sys_proto.h | 2 +- arch/arm/include/asm/arch-mx6/litesom.h | 2 +- arch/arm/include/asm/arch-mxs/sys_proto.h | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) (limited to 'arch/arm/include/asm') diff --git a/arch/arm/include/asm/arch-mx27/mxcmmc.h b/arch/arm/include/asm/arch-mx27/mxcmmc.h index d7b5ca20aa..52fb0ab578 100644 --- a/arch/arm/include/asm/arch-mx27/mxcmmc.h +++ b/arch/arm/include/asm/arch-mx27/mxcmmc.h @@ -6,6 +6,6 @@ #ifndef ASM_ARCH_MXCMMC_H #define ASM_ARCH_MXCMMC_H -int mxc_mmc_init(bd_t *bis); +int mxc_mmc_init(struct bd_info *bis); #endif diff --git a/arch/arm/include/asm/arch-mx31/sys_proto.h b/arch/arm/include/asm/arch-mx31/sys_proto.h index e4087889b4..29fc0fda0e 100644 --- a/arch/arm/include/asm/arch-mx31/sys_proto.h +++ b/arch/arm/include/asm/arch-mx31/sys_proto.h @@ -16,5 +16,5 @@ struct mxc_weimcs { }; void mxc_setup_weimcs(int cs, const struct mxc_weimcs *weimcs); -int mxc_mmc_init(bd_t *bis); +int mxc_mmc_init(struct bd_info *bis); #endif diff --git a/arch/arm/include/asm/arch-mx6/litesom.h b/arch/arm/include/asm/arch-mx6/litesom.h index fcdfcab9ea..37a16d2c30 100644 --- a/arch/arm/include/asm/arch-mx6/litesom.h +++ b/arch/arm/include/asm/arch-mx6/litesom.h @@ -6,7 +6,7 @@ #ifndef __ARCH_ARM_MX6UL_LITESOM_H__ #define __ARCH_ARM_MX6UL_LITESOM_H__ -int litesom_mmc_init(bd_t *bis); +int litesom_mmc_init(struct bd_info *bis); #ifdef CONFIG_SPL_BUILD void litesom_init_f(void); diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h index 6478692a9c..20ee863ac7 100644 --- a/arch/arm/include/asm/arch-mxs/sys_proto.h +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h @@ -11,7 +11,8 @@ #include -int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int), int (*cd)(int)); +int mxsmmc_initialize(struct bd_info *bis, int id, int (*wp)(int), + int (*cd)(int)); #ifdef CONFIG_SPL_BUILD -- cgit v1.2.1