From 3815803633a6d3bbde7e0cb9118b834e805cb409 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Wed, 21 Sep 2022 17:42:58 +0300 Subject: protocol: reorder wl_data_offer.source_actions and wl_data_device.enter Most compositors send the wl_data_offer.source_actions event before the wl_data_device.enter event, i.e. after creation of the data offer. This contradicts to the wayland spec. On the other hand, it's reasonable to send all the information useful to the client before the enter event, rather than send mime types before the enter event and source actions (that don't depend on drop target) after the enter event. On the client side, toolkits such as Qt and GTK already expect to see the source actions before receiving the enter event. Given all of that, this change adjusts the spec to match the behavior observed in the compositors in the wild. Signed-off-by: Vlad Zahorodnii --- protocol/wayland.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 07cd6bc..0ab57b8 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -630,8 +630,9 @@ This event indicates the actions offered by the data source. It - will be sent right after wl_data_device.enter, or anytime the source - side changes its offered actions through wl_data_source.set_actions. + will be sent immediately after creating the wl_data_offer object, + or anytime the source side changes its offered actions through + wl_data_source.set_actions. -- cgit v1.2.1