From 000abcd371d0c4b1d0a5380023d74bf5bfc47685 Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Fri, 2 Jun 2006 19:33:29 +0000 Subject: Coverity #1415: Returned without freeing storage "hints_cmt" (in error case when xpmHashTableInit failed) --- ChangeLog | 6 ++++++ src/parse.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index c18f6dd..8f2928d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-06-02 Alan Coopersmith + + * src/parse.c (xpmParseData): + Coverity #1415: Returned without freeing storage "hints_cmt" + (in error case when xpmHashTableInit failed) + 2006-04-26 Adam Jackson * configure.ac: diff --git a/src/parse.c b/src/parse.c index 9644181..c5ec1a1 100644 --- a/src/parse.c +++ b/src/parse.c @@ -1,4 +1,4 @@ -/* $XdotOrg: xc/extras/Xpm/lib/parse.c,v 1.2.4.1 2004/09/15 15:47:39 daniel Exp $ */ +/* $XdotOrg: lib/Xpm/src/parse.c,v 1.6 2005/07/16 21:11:25 alanc Exp $ */ /* * Copyright (C) 1989-95 GROUPE BULL * @@ -702,12 +702,12 @@ xpmParseData(data, image, info) xpmGetCmt(data, &hints_cmt); /* - * init the hastable + * init the hashtable */ if (USE_HASHTABLE) { ErrorStatus = xpmHashTableInit(&hashtable); if (ErrorStatus != XpmSuccess) - return (ErrorStatus); + RETURN(ErrorStatus); } /* -- cgit v1.2.1