diff options
author | Enrico Olivelli <eolivelli@apache.org> | 2022-06-01 17:33:57 +0200 |
---|---|---|
committer | Mate Szalay-Beko <symat@apache.com> | 2022-06-01 17:33:57 +0200 |
commit | 7a515fee0124eea389c599995915927e49cf4c57 (patch) | |
tree | 51faf858dc05ae8111a960d97c767e4c6141328f | |
parent | 4b1b33e72ca819258b8675948b9a80dd6290edb0 (diff) | |
download | zookeeper-7a515fee0124eea389c599995915927e49cf4c57.tar.gz |
ZOOKEEPER-4551: Do not log spammy stacktrace when a client closes its connection
Motivation:
See more here https://issues.apache.org/jira/browse/ZOOKEEPER-4551
Modifications:
Do not log the stacktrace, just write the message at INFO level
Author: Enrico Olivelli <eolivelli@apache.org>
Reviewers: Mate Szalay-Beko <symat@apache.org>
Closes #1889 from eolivelli/fix/remove-spam-stacktrace
-rw-r--r-- | zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java index 02cde23a9..dd62154fc 100644 --- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java +++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java @@ -330,7 +330,15 @@ public class NIOServerCnxn extends ServerCnxn { if (k.isReadable()) { int rc = sock.read(incomingBuffer); if (rc < 0) { - handleFailedRead(); + try { + handleFailedRead(); + } catch (EndOfStreamException e) { + // no stacktrace. this case is very common, and it is usually not a problem. + LOG.info("{}", e.getMessage()); + // expecting close to log session closure + close(e.getReason()); + return; + } } if (incomingBuffer.remaining() == 0) { boolean isPayload; |