summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Wirzenius <lars.wirzenius@codethink.co.uk>2014-04-22 14:36:24 +0000
committerLars Wirzenius <lars.wirzenius@codethink.co.uk>2014-04-22 14:36:24 +0000
commitfa53202db029c6cef266c40e8be5fde17b60af91 (patch)
tree9058c910d74a7b0dd5052b3961299c175be058f3
parent9cf8249d8cf06ee9be78cd89bb483ac05bdf66b6 (diff)
downloadlorry-controller-fa53202db029c6cef266c40e8be5fde17b60af91.tar.gz
Remove dead code, update FIXME comment
-rw-r--r--lorrycontroller/givemejob.py9
1 files changed, 4 insertions, 5 deletions
diff --git a/lorrycontroller/givemejob.py b/lorrycontroller/givemejob.py
index 067f3c3..44bf9f7 100644
--- a/lorrycontroller/givemejob.py
+++ b/lorrycontroller/givemejob.py
@@ -112,11 +112,10 @@ class GiveMeJob(lorrycontroller.LorryControllerRoute):
desc)
except lorrycontroller.GitanoCommandFailure as e:
logging.error('ERROR: %s' % str(e))
- # FIXME: The following is commented out, for now. We need
- # a good way to report such errors. However, we probably
- # don't want to fail the request.
- if False:
- bottle.abort(500)
+ # FIXME: We need a good way to report these errors to the
+ # user. However, we probably don't want to fail the
+ # request, so that's not the way to do this. Needs
+ # thinking.
def give_job_to_minion(self, statedb, lorry_info, now):
path = lorry_info['path']