Allow creating repos/groups as internal or public on GitLab

GitLab groups can have a visibility of 'private' (only members),
'internal'/'limited' (only authenticated users), or 'public' (anyone).

GitLab subgroups and projects can have the same visibilities as
groups, but cannot be more visible than the containing group.

When mirroring public source code, it may be desirable to make the
entities we create more visible than the current default of 'private'.

Add an option to set any of the three levels of visibility supported
by GitLab, with the default unchanged.  (The same levels are supported
by Gitea, though with one named differently.)  Never change the
visibility of a group or repository that already exists.

Note that the GitLab connector previously tried to create all projects
as public, but this stopped working after the change to API v4.

In Gerrit and Gitano the access control model is lot more complex, and
generally only administrators can set visibility.  Make their
connectors reject visibility other than 'private'.

Relates to #6, #9.

1 files changed, 5 insertions, 0 deletions

diff --git a/lorry-controller-webapp b/lorry-controller-webapp
index 6fc827e..2c99c08 100755
--- a/lorry-controller-webapp
+++ b/lorry-controller-webapp
@@ -143,6 +143,11 @@ class WEBAPP(cliapp.Application):
             ['publish-failures'],
             'make the status page show failure logs from lorry')
 
+        self.settings.choice(
+            ['downstream-visibility'],
+            ['private', 'internal', 'public'],
+            'Visibility of repositories created on Downstream Host (GitLab)')
+
         for downstream_type in lorrycontroller.downstream_types.values():
             downstream_type.add_app_settings(self.settings)