diff options
author | Kyle Mckay <kyle.mckay@codethink.co.uk> | 2022-01-05 13:49:27 +0000 |
---|---|---|
committer | Kyle Mckay <kyle.mckay@codethink.co.uk> | 2022-01-12 11:10:05 +0000 |
commit | 1a1acf5ca41c4ffca5a9f94d770f852335111048 (patch) | |
tree | ecff3c56c2b61f77cd65bfd99859e47f253d210b /yarns.webapp | |
parent | 286b50ee969bad45a9f11df96c6a36d513310a51 (diff) | |
download | lorry-controller-1a1acf5ca41c4ffca5a9f94d770f852335111048.tar.gz |
Fix job queue getting stuck on repo preparation
- When a downstream type failed to prepare a repository the loop over
lorries would abort unexpectly meaning any following lorries were
never added into the minion's queue. Such cases are now simply skipped
over so that lorry controller does not get stuck.
- Catching Exception doesn't feel nice or correct, but we don't want any
unexpected exceptions to cause the same problem of getting stuck so I
don't see any obvious alternative in the short term. Perhaps the
overall code can be reworked to avoid needing to do this.
Log exceptions when skipping lorries
When a repository fails to prepare, ensure there is a log of the
exception that occured and the associated lorry.
Update skipped lorry last run and exit data
- Update last run to prevent frequent repeated failure
- Update exit for user visiblity on status page
Diffstat (limited to 'yarns.webapp')
0 files changed, 0 insertions, 0 deletions