ChangeLogTag: Tue Feb 20 16:26:39 UTC 2007 Jaiganesh B <jai.dre.vanderbilt.edu>DS-branch

2 files changed, 26 insertions, 0 deletions

diff --git a/modules/TAO/ChangeLog b/modules/TAO/ChangeLog
index 8d4c7cdb64f..45827e9ad1e 100644
--- a/modules/TAO/ChangeLog
+++ b/modules/TAO/ChangeLog
@@ -1,3 +1,11 @@
+Tue Feb 20 16:26:39 UTC 2007  Jaiganesh B  <jai.dre.vanderbilt.edu>
+
+        * tao/Remote_Invocation.cpp:
+        
+          Added some notes in the send_message () method to explain
+          how RTCORBA and DiffServ policy can work together to set
+          DiffServ codepoints.
+
 Thu Feb 15 02:28:56 UTC 2007  Jaiganesh B  <jai.dre.vanderbilt.edu>
 
         * tests/DiffServ/README:
diff --git a/modules/TAO/tao/Remote_Invocation.cpp b/modules/TAO/tao/Remote_Invocation.cpp
index 2fdffbbfb5d..a046af6f2a9 100644
--- a/modules/TAO/tao/Remote_Invocation.cpp
+++ b/modules/TAO/tao/Remote_Invocation.cpp
@@ -151,6 +151,24 @@ namespace TAO
     TAO_Connection_Handler *connection_handler =
       this->resolver_.transport ()->connection_handler ();
 
+    // This code checks first if RTCORBA way of setting DiffServ codepoints
+    // is defined.
+    // The "set_client_network_priority" flag will be 1 if RTCORBA
+    // is setting the DiffServ codepoints.
+    // If not, we check if the DiffServ policy is used to set the DiffServ
+    // codepoint.
+    // We will have to change this to check on the DiffServ policy first.
+    // But then the proper values of DiffServ codepoints problem happens.
+    // You had suggested me to have a flag on if the real values
+    // are set or not.
+    // Instead, we could go with a flag.
+    // In the Default_Network_Priority_Protocols_Hook, that flag could be
+    // 0.
+    // In the DiffServ_Protocols_Hooks, the flag could be 1.
+    // So by checking on the flag, we can decide if the DiffServ policy is 
+    // properly used.
+    //
+
     if (set_client_network_priority)
       {
         // RTCORBA is used and the RTCORBA way of setting DiffServ codepoints