diff options
author | Johnny Willemsen <jwillemsen@remedy.nl> | 2023-01-17 09:44:30 +0100 |
---|---|---|
committer | Johnny Willemsen <jwillemsen@remedy.nl> | 2023-01-17 09:44:30 +0100 |
commit | 73bdf800479e53a11143735e48348bb88c527c24 (patch) | |
tree | 03252f3055dd58fcfc99a70c53aca435eb61dbc2 /ACE/tests | |
parent | 016eb1b3caa7b8ba0ff4c479895151eca984c82b (diff) | |
download | ATCD-73bdf800479e53a11143735e48348bb88c527c24.tar.gz |
Cleanup Solaris support
Diffstat (limited to 'ACE/tests')
-rw-r--r-- | ACE/tests/Array_Map_Test.cpp | 6 | ||||
-rw-r--r-- | ACE/tests/Compiler_Features_09_Test.cpp | 4 | ||||
-rw-r--r-- | ACE/tests/Dynamic_Priority_Test.cpp | 2 | ||||
-rw-r--r-- | ACE/tests/IOStream_Test.cpp | 10 | ||||
-rw-r--r-- | ACE/tests/Multicast_Test.cpp | 2 | ||||
-rw-r--r-- | ACE/tests/Multicast_Test_IPV6.cpp | 2 | ||||
-rw-r--r-- | ACE/tests/Priority_Task_Test.cpp | 6 | ||||
-rw-r--r-- | ACE/tests/Service_Config_Test.cpp | 4 | ||||
-rw-r--r-- | ACE/tests/Signal_Test.cpp | 2 | ||||
-rw-r--r-- | ACE/tests/Thread_Creation_Threshold_Test.cpp | 6 |
10 files changed, 11 insertions, 33 deletions
diff --git a/ACE/tests/Array_Map_Test.cpp b/ACE/tests/Array_Map_Test.cpp index 9d8ad4448ce..ad972a8eb43 100644 --- a/ACE/tests/Array_Map_Test.cpp +++ b/ACE/tests/Array_Map_Test.cpp @@ -412,9 +412,6 @@ reference_count_test () std::pair<Map::iterator, bool> result; { - // Enter a new scope block to assure destruction of temporaries - // on systems like Solaris / Sun C++. - result = map.insert (std::make_pair (ACE_TString (ACE_TEXT ("Two")), counted)); @@ -424,9 +421,6 @@ reference_count_test () ACE_TEST_ASSERT (counted.refcount () == 3); { - // Enter a new scope block to assure destruction of temporaries - // on systems like Solaris / Sun C++. - result = map.insert (std::make_pair (ACE_TString (ACE_TEXT ("Three")), counted)); diff --git a/ACE/tests/Compiler_Features_09_Test.cpp b/ACE/tests/Compiler_Features_09_Test.cpp index c765724237a..28e0be3cdc1 100644 --- a/ACE/tests/Compiler_Features_09_Test.cpp +++ b/ACE/tests/Compiler_Features_09_Test.cpp @@ -71,10 +71,6 @@ run_main (int, ACE_TCHAR *[]) // ... with a compliant implementation of std::auto_ptr<> you should be // able to write: // x = y; - // but the Solaris compiler was broken as of August, 2009!! So you have - // to work around in the following way. This compiler is important - // enough for the ACE community, so we have to support this broken - // configuration ... x.reset(y.release()); // ... there should be just one destruction so far ... diff --git a/ACE/tests/Dynamic_Priority_Test.cpp b/ACE/tests/Dynamic_Priority_Test.cpp index de5939b43ed..0d2ec3ff127 100644 --- a/ACE/tests/Dynamic_Priority_Test.cpp +++ b/ACE/tests/Dynamic_Priority_Test.cpp @@ -697,7 +697,7 @@ run_main (int, ACE_TCHAR *[]) ACE_START_TEST (ACE_TEXT ("Dynamic_Priority_Test")); #if defined (ACE_HAS_TIMED_MESSAGE_BLOCKS) - // Enable FIFO scheduling, e.g., RT scheduling class on Solaris. + // Enable FIFO scheduling if (ACE_OS::sched_params ( ACE_Sched_Params ( ACE_SCHED_FIFO, diff --git a/ACE/tests/IOStream_Test.cpp b/ACE/tests/IOStream_Test.cpp index 46ca847729a..7901b5e84cf 100644 --- a/ACE/tests/IOStream_Test.cpp +++ b/ACE/tests/IOStream_Test.cpp @@ -153,9 +153,8 @@ client (void *arg = 0) // We don't _need_ to dynamically allocate the ACE_SOCK_IOStream. // But if we don't, it doesn't get destroyed on some platforms, - // e.g., g++ 2.7.2.1 and Sun C++ 4.2 on Solaris 2.5.1. (It does work - // on Linux, so the code seems fine.) If we manage the storage - // ourselves, we _will_ destroy it at the end of this function. + // If we manage the storage ourselves, we _will_ destroy it at + // the end of this function. ACE_SOCK_IOStream server; ACE_INET_Addr *remote_addr = (ACE_INET_Addr *) arg; @@ -269,9 +268,8 @@ server (void *arg = 0) { // We don't _need_ to dynamically allocate the ACE_SOCK_IOStream. // But if we don't, it doesn't get destroyed on some platforms, - // e.g., g++ 2.7.2.1 and Sun C++ 4.2 on Solaris 2.5.1. (It does work - // on Linux, so the code seems fine.) If we manage the storage - // ourselves, we _will_ destroy it at the end of this function. + // If we manage the storage ourselves, we _will_ destroy it at + // the end of this function. ACE_SOCK_IOStream client_handler; ACE_INET_Addr server_addr; diff --git a/ACE/tests/Multicast_Test.cpp b/ACE/tests/Multicast_Test.cpp index c00aaa347b0..524767532ec 100644 --- a/ACE/tests/Multicast_Test.cpp +++ b/ACE/tests/Multicast_Test.cpp @@ -255,7 +255,7 @@ MCT_Config::open (int argc, ACE_TCHAR *argv[]) { int n = ACE_OS::atoi (getopt.opt_arg ()); // I'm assuming 0 means unlimited, so just use whatever the - // user provides. Seems to work okay on Solaris 5.8. + // user provides. if (IP_MAX_MEMBERSHIPS == 0) this->groups_ = n; else diff --git a/ACE/tests/Multicast_Test_IPV6.cpp b/ACE/tests/Multicast_Test_IPV6.cpp index 65347b3bf7d..11056ef53c7 100644 --- a/ACE/tests/Multicast_Test_IPV6.cpp +++ b/ACE/tests/Multicast_Test_IPV6.cpp @@ -265,7 +265,7 @@ MCT_Config::open (int argc, ACE_TCHAR *argv[]) { int n = ACE_OS::atoi (getopt.opt_arg ()); // I'm assuming 0 means unlimited, so just use whatever the - // user provides. Seems to work okay on Solaris 5.8. + // user provides. if (IP_MAX_MEMBERSHIPS == 0) this->groups_ = n; else diff --git a/ACE/tests/Priority_Task_Test.cpp b/ACE/tests/Priority_Task_Test.cpp index 91a16596730..305c7f0aa83 100644 --- a/ACE/tests/Priority_Task_Test.cpp +++ b/ACE/tests/Priority_Task_Test.cpp @@ -199,12 +199,6 @@ run_main (int argc, ACE_TCHAR *argv[]) // Spawn off ACE_MAX_ITERATIONS of tasks, passing each one their // iteration number as their priority. - - // NOTE: on Solaris, for example, this requests the min FIFO - // priority. But, this test doesn't use the Realtime scheduling - // class. The FIFO priorities are used because they're all - // nonnegative. - ACE_Sched_Priority_Iterator priority (ACE_SCHED_FIFO, ACE_SCOPE_THREAD); diff --git a/ACE/tests/Service_Config_Test.cpp b/ACE/tests/Service_Config_Test.cpp index 78f8dd5e38b..859d7d33cb2 100644 --- a/ACE/tests/Service_Config_Test.cpp +++ b/ACE/tests/Service_Config_Test.cpp @@ -183,7 +183,7 @@ testLoadingServiceConfFileAndProcessNo (int argc, ACE_TCHAR *argv[]) // Configurator file appropriate to the platform. // For example, Windows Unicode uses UTF-16. // - // iconv(1) found on Linux and Solaris, for example, can + // iconv(1) found on Linux, for example, can // be used to convert between encodings. // // Byte ordering is also an issue, so we should be @@ -285,7 +285,7 @@ testLoadingServiceConfFile (int argc, ACE_TCHAR *argv[]) // Configurator file appropriate to the platform. // For example, Windows Unicode uses UTF-16. // - // iconv(1) found on Linux and Solaris, for example, can + // iconv(1) found on Linux, for example, can // be used to convert between encodings. // // Byte ordering is also an issue, so we should be diff --git a/ACE/tests/Signal_Test.cpp b/ACE/tests/Signal_Test.cpp index 29f40c78eb9..25cf75a6e5d 100644 --- a/ACE/tests/Signal_Test.cpp +++ b/ACE/tests/Signal_Test.cpp @@ -336,7 +336,7 @@ run_test (ACE_THR_FUNC worker, { // For the synchronous signal tests, block signals to prevent // asynchronous delivery to default handler (at least necessary - // on linux and solaris; POSIX spec also states that signal(s) + // on linux ; POSIX spec also states that signal(s) // should be blocked before call to sigwait()) ACE_Sig_Guard guard; diff --git a/ACE/tests/Thread_Creation_Threshold_Test.cpp b/ACE/tests/Thread_Creation_Threshold_Test.cpp index a84bd553651..1627e013309 100644 --- a/ACE/tests/Thread_Creation_Threshold_Test.cpp +++ b/ACE/tests/Thread_Creation_Threshold_Test.cpp @@ -6,11 +6,7 @@ * This test program stresses how many threads can be * consecutively (not simultaneously) created on a platform. * Rather than testing exhaustively, it establishes a - * semi-arbitrary upper limit (MAX_THREAD)of threads. The limit - * is only partly arbitrary because it was chosen as a value that - * exceeded an observed upper limit on the values that Solaris 9 - * will accept as arguments to thr_concurrency(), used by - * ACE_OS::thr_create(THR_NEW_LWP). + * semi-arbitrary upper limit (MAX_THREAD)of threads. * * @author Chris Cleeland <cleeland@ociweb.com> */ |