summaryrefslogtreecommitdiff
path: root/ACE
diff options
context:
space:
mode:
authorJohnny Willemsen <jwillemsen@remedy.nl>2010-07-12 11:05:04 +0000
committerJohnny Willemsen <jwillemsen@remedy.nl>2010-07-12 11:05:04 +0000
commit1e140f84b5bcac153e95c2e6cf83436f15ee8596 (patch)
tree861124f3162a9c3518e552e7074c28d0694e5e9a /ACE
parent286eedd2fc603c3c384ae9dd0d70133bd0694474 (diff)
downloadATCD-1e140f84b5bcac153e95c2e6cf83436f15ee8596.tar.gz
Mon Jul 12 11:04:58 UTC 2010 Johnny Willemsen <jwillemsen@remedy.nl>
* ace/ACE.cpp: * ace/Activation_Queue.h: * ace/Active_Map_Manager.h: * ace/Dev_Poll_Reactor.h: * ace/Dev_Poll_Reactor.inl: * ace/Event_Handler.h: * ace/Filecache.h: * ace/Manual_Event.h: * ace/Map_Manager.h: * ace/Mem_Map.h: * ace/Message_Block.h: * ace/OS_Log_Msg_Attributes.h: * ace/OS_NS_unistd.h: * ace/Object_Manager.h: * ace/Recursive_Thread_Mutex.h: Layout, const, and doxygen fixes
Diffstat (limited to 'ACE')
-rw-r--r--ACE/ChangeLog19
-rw-r--r--ACE/ace/ACE.cpp98
-rw-r--r--ACE/ace/Activation_Queue.h13
-rw-r--r--ACE/ace/Active_Map_Manager.h2
-rw-r--r--ACE/ace/Dev_Poll_Reactor.h50
-rw-r--r--ACE/ace/Dev_Poll_Reactor.inl12
-rw-r--r--ACE/ace/Event_Handler.h14
-rw-r--r--ACE/ace/Filecache.h11
-rw-r--r--ACE/ace/Manual_Event.h4
-rw-r--r--ACE/ace/Map_Manager.h15
-rw-r--r--ACE/ace/Mem_Map.h21
-rw-r--r--ACE/ace/Message_Block.h4
-rw-r--r--ACE/ace/OS_Log_Msg_Attributes.h12
-rw-r--r--ACE/ace/OS_NS_unistd.h4
-rw-r--r--ACE/ace/Object_Manager.h17
-rw-r--r--ACE/ace/Recursive_Thread_Mutex.h8
16 files changed, 115 insertions, 189 deletions
diff --git a/ACE/ChangeLog b/ACE/ChangeLog
index 40046aa3828..e2079090d66 100644
--- a/ACE/ChangeLog
+++ b/ACE/ChangeLog
@@ -1,3 +1,22 @@
+Mon Jul 12 11:04:58 UTC 2010 Johnny Willemsen <jwillemsen@remedy.nl>
+
+ * ace/ACE.cpp:
+ * ace/Activation_Queue.h:
+ * ace/Active_Map_Manager.h:
+ * ace/Dev_Poll_Reactor.h:
+ * ace/Dev_Poll_Reactor.inl:
+ * ace/Event_Handler.h:
+ * ace/Filecache.h:
+ * ace/Manual_Event.h:
+ * ace/Map_Manager.h:
+ * ace/Mem_Map.h:
+ * ace/Message_Block.h:
+ * ace/OS_Log_Msg_Attributes.h:
+ * ace/OS_NS_unistd.h:
+ * ace/Object_Manager.h:
+ * ace/Recursive_Thread_Mutex.h:
+ Layout, const, and doxygen fixes
+
Mon Jul 12 10:11:24 UTC 2010 Johnny Willemsen <jwillemsen@remedy.nl>
* ace/DLL.h:
diff --git a/ACE/ace/ACE.cpp b/ACE/ace/ACE.cpp
index 03c35fc991d..f46e8219d0f 100644
--- a/ACE/ace/ACE.cpp
+++ b/ACE/ace/ACE.cpp
@@ -658,8 +658,7 @@ ACE::recv_n_i (ACE_HANDLE handle,
errno == EWOULDBLOCK)
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_read_ready (handle,
- timeout);
+ int const rtn = ACE::handle_read_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
@@ -720,8 +719,7 @@ ACE::t_rcv_n_i (ACE_HANDLE handle,
if (errno == EWOULDBLOCK)
{
// Wait for the blocking to subside.
- int result = ACE::handle_read_ready (handle,
- 0);
+ int const result = ACE::handle_read_ready (handle, 0);
// Did select() succeed?
if (result != -1)
@@ -778,8 +776,7 @@ ACE::t_rcv_n_i (ACE_HANDLE handle,
errno == EWOULDBLOCK)
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_read_ready (handle,
- timeout);
+ int const rtn = ACE::handle_read_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
@@ -839,8 +836,7 @@ ACE::recv_n_i (ACE_HANDLE handle,
if (errno == EWOULDBLOCK)
{
// Wait for the blocking to subside.
- int result = ACE::handle_read_ready (handle,
- 0);
+ int const result = ACE::handle_read_ready (handle, 0);
// Did select() succeed?
if (result != -1)
@@ -895,8 +891,7 @@ ACE::recv_n_i (ACE_HANDLE handle,
errno == EWOULDBLOCK)
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_read_ready (handle,
- timeout);
+ int const rtn = ACE::handle_read_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
@@ -934,8 +929,8 @@ ssize_t
ACE::recv (ACE_HANDLE handle, size_t n, ...)
{
va_list argp;
- int total_tuples = static_cast<int> (n / 2);
- iovec *iovp;
+ int const total_tuples = static_cast<int> (n / 2);
+ iovec *iovp = 0;
#if defined (ACE_HAS_ALLOCA)
iovp = (iovec *) alloca (total_tuples * sizeof (iovec));
#else
@@ -952,7 +947,7 @@ ACE::recv (ACE_HANDLE handle, size_t n, ...)
iovp[i].iov_len = va_arg (argp, int);
}
- ssize_t result = ACE_OS::recvv (handle, iovp, total_tuples);
+ ssize_t const result = ACE_OS::recvv (handle, iovp, total_tuples);
#if !defined (ACE_HAS_ALLOCA)
delete [] iovp;
#endif /* !defined (ACE_HAS_ALLOCA) */
@@ -992,14 +987,10 @@ ACE::recvv_n_i (ACE_HANDLE handle,
size_t &bytes_transferred = bt == 0 ? temp : *bt;
bytes_transferred = 0;
- for (int s = 0;
- s < iovcnt;
- )
+ for (int s = 0; s < iovcnt; )
{
// Try to transfer as much of the remaining data as possible.
- ssize_t n = ACE_OS::recvv (handle,
- iov + s,
- iovcnt - s);
+ ssize_t n = ACE_OS::recvv (handle, iov + s, iovcnt - s);
// Check EOF.
if (n == 0)
return 0;
@@ -1011,8 +1002,7 @@ ACE::recvv_n_i (ACE_HANDLE handle,
if (errno == EWOULDBLOCK)
{
// Wait for the blocking to subside.
- int result = ACE::handle_read_ready (handle,
- 0);
+ int const result = ACE::handle_read_ready (handle, 0);
// Did select() succeed?
if (result != -1)
@@ -1060,28 +1050,21 @@ ACE::recvv_n_i (ACE_HANDLE handle,
int val = 0;
ACE::record_and_set_non_blocking_mode (handle, val);
- for (int s = 0;
- s < iovcnt;
- )
+ for (int s = 0; s < iovcnt; )
{
// Try to transfer as much of the remaining data as possible.
// Since the socket is in non-blocking mode, this call will not
// block.
- ssize_t n = ACE_OS::recvv (handle,
- iov + s,
- iovcnt - s);
+ ssize_t n = ACE_OS::recvv (handle, iov + s, iovcnt - s);
// Check for errors.
- if (n == 0 ||
- n == -1)
+ if (n == 0 || n == -1)
{
// Check for possible blocking.
- if (n == -1 &&
- errno == EWOULDBLOCK)
+ if (n == -1 && errno == EWOULDBLOCK)
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_read_ready (handle,
- timeout);
+ int const rtn = ACE::handle_read_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
@@ -1242,7 +1225,8 @@ ACE::send (ACE_HANDLE handle,
return -1;
else
{
- ssize_t bytes_transferred = ACE_OS::send (handle, (const char *) buf, n, flags);
+ ssize_t const bytes_transferred =
+ ACE_OS::send (handle, (const char *) buf, n, flags);
ACE::restore_non_blocking_mode (handle, val);
return bytes_transferred;
}
@@ -1267,7 +1251,8 @@ ACE::t_snd (ACE_HANDLE handle,
return -1;
else
{
- ssize_t bytes_transferred = ACE_OS::t_snd (handle, (const char *) buf, n, flags);
+ ssize_t const bytes_transferred =
+ ACE_OS::t_snd (handle, (const char *) buf, n, flags);
ACE::restore_non_blocking_mode (handle, val);
return bytes_transferred;
}
@@ -1291,7 +1276,7 @@ ACE::send (ACE_HANDLE handle,
return -1;
else
{
- ssize_t bytes_transferred = ACE::send_i (handle, buf, n);
+ ssize_t const bytes_transferred = ACE::send_i (handle, buf, n);
ACE::restore_non_blocking_mode (handle, val);
return bytes_transferred;
}
@@ -1313,7 +1298,8 @@ ACE::sendmsg (ACE_HANDLE handle,
return -1;
else
{
- ssize_t bytes_transferred = ACE_OS::sendmsg (handle, msg, flags);
+ ssize_t const bytes_transferred =
+ ACE_OS::sendmsg (handle, msg, flags);
ACE::restore_non_blocking_mode (handle, val);
return bytes_transferred;
}
@@ -1338,7 +1324,7 @@ ACE::sendto (ACE_HANDLE handle,
return -1;
else
{
- ssize_t bytes_transferred =
+ ssize_t const bytes_transferred =
ACE_OS::sendto (handle, buf, len, flags, addr, addrlen);
ACE::restore_non_blocking_mode (handle, val);
return bytes_transferred;
@@ -1381,8 +1367,7 @@ ACE::send_n_i (ACE_HANDLE handle,
#endif /* ACE_WIN32 */
{
// Wait for the blocking to subside.
- int result = ACE::handle_write_ready (handle,
- 0);
+ int const result = ACE::handle_write_ready (handle, 0);
// Did select() succeed?
if (result != -1)
@@ -1435,12 +1420,10 @@ ACE::send_n_i (ACE_HANDLE handle,
n == -1)
{
// Check for possible blocking.
- if (n == -1 &&
- (errno == EWOULDBLOCK || errno == ENOBUFS))
+ if (n == -1 && (errno == EWOULDBLOCK || errno == ENOBUFS))
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_write_ready (handle,
- timeout);
+ int const rtn = ACE::handle_write_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
@@ -1505,8 +1488,7 @@ ACE::t_snd_n_i (ACE_HANDLE handle,
if (errno == EWOULDBLOCK || errno == ENOBUFS)
{
// Wait for the blocking to subside.
- int result = ACE::handle_write_ready (handle,
- 0);
+ int const result = ACE::handle_write_ready (handle, 0);
// Did select() succeed?
if (result != -1)
@@ -1563,8 +1545,7 @@ ACE::t_snd_n_i (ACE_HANDLE handle,
errno == EWOULDBLOCK || errno == ENOBUFS)
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_write_ready (handle,
- timeout);
+ int const rtn = ACE::handle_write_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
@@ -1625,8 +1606,7 @@ ACE::send_n_i (ACE_HANDLE handle,
if (errno == EWOULDBLOCK || errno == ENOBUFS)
{
// Wait for the blocking to subside.
- int result = ACE::handle_write_ready (handle,
- 0);
+ int const result = ACE::handle_write_ready (handle, 0);
// Did select() succeed?
if (result != -1)
@@ -1681,8 +1661,7 @@ ACE::send_n_i (ACE_HANDLE handle,
(errno == EWOULDBLOCK || errno == ENOBUFS))
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_write_ready (handle,
- timeout);
+ int const rtn = ACE::handle_write_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
@@ -1788,9 +1767,8 @@ ACE::sendv_n_i (ACE_HANDLE handle,
)
{
// Try to transfer as much of the remaining data as possible.
- ssize_t n = ACE_OS::sendv (handle,
- iov + s,
- iovcnt - s);
+ ssize_t n = ACE_OS::sendv (handle, iov + s, iovcnt - s);
+
// Check EOF.
if (n == 0)
return 0;
@@ -1802,8 +1780,7 @@ ACE::sendv_n_i (ACE_HANDLE handle,
if (errno == EWOULDBLOCK || errno == ENOBUFS)
{
// Wait for the blocking to subside.
- int result = ACE::handle_write_ready (handle,
- 0);
+ int const result = ACE::handle_write_ready (handle, 0);
// Did select() succeed?
if (result != -1)
@@ -1860,9 +1837,7 @@ ACE::sendv_n_i (ACE_HANDLE handle,
// Try to transfer as much of the remaining data as possible.
// Since the socket is in non-blocking mode, this call will not
// block.
- ssize_t n = ACE_OS::sendv (handle,
- iov + s,
- iovcnt - s);
+ ssize_t n = ACE_OS::sendv (handle, iov + s, iovcnt - s);
// Check for errors.
if (n == 0 ||
@@ -1873,8 +1848,7 @@ ACE::sendv_n_i (ACE_HANDLE handle,
(errno == EWOULDBLOCK || errno == ENOBUFS))
{
// Wait upto <timeout> for the blocking to subside.
- int rtn = ACE::handle_write_ready (handle,
- timeout);
+ int const rtn = ACE::handle_write_ready (handle, timeout);
// Did select() succeed?
if (rtn != -1)
diff --git a/ACE/ace/Activation_Queue.h b/ACE/ace/Activation_Queue.h
index 87fffc0f73d..a356b1f0a34 100644
--- a/ACE/ace/Activation_Queue.h
+++ b/ACE/ace/Activation_Queue.h
@@ -23,6 +23,7 @@
#endif /* ACE_LACKS_PRAGMA_ONCE */
#include "ace/Message_Queue.h"
+#include "ace/Copy_Disabled.h"
#include "ace/Condition_Thread_Mutex.h"
/// Define to be compatible with the terminology in the POSA2 book!
@@ -35,7 +36,8 @@ class ACE_Method_Request;
/**
* @class ACE_Activation_Queue
*
- * @brief Reifies a method into a request. Subclasses typically
+ * @brief
+ * Reifies a method into a request. Subclasses typically
* represent necessary state and behavior.
*
* Maintains a priority-ordered queue of ACE_Method_Request objects.
@@ -47,10 +49,9 @@ class ACE_Method_Request;
*
* @sa ACE_Method_Request
*/
-class ACE_Export ACE_Activation_Queue
+class ACE_Export ACE_Activation_Queue : private ACE_Copy_Disabled
{
public:
- // = Initialization and termination methods.
/// Constructor.
/**
* Initializes a new activation queue.
@@ -139,12 +140,6 @@ public:
/// Declare the dynamic allocation hooks.
ACE_ALLOC_HOOK_DECLARE;
-private:
-
- // = Prevent copying and assignment.
- ACE_Activation_Queue (const ACE_Activation_Queue &);
- void operator= (const ACE_Activation_Queue &);
-
protected:
/// Stores the Method_Requests.
diff --git a/ACE/ace/Active_Map_Manager.h b/ACE/ace/Active_Map_Manager.h
index c9cc0349958..4a53b81a018 100644
--- a/ACE/ace/Active_Map_Manager.h
+++ b/ACE/ace/Active_Map_Manager.h
@@ -95,7 +95,7 @@ private:
/// Slot index in the active map.
ACE_UINT32 slot_index_;
- /// Slot generation number of <slot_index_> slot in the active map.
+ /// Slot generation number of @c slot_index_ slot in the active map.
ACE_UINT32 slot_generation_;
};
diff --git a/ACE/ace/Dev_Poll_Reactor.h b/ACE/ace/Dev_Poll_Reactor.h
index 878e7a8f78c..dadcf69035e 100644
--- a/ACE/ace/Dev_Poll_Reactor.h
+++ b/ACE/ace/Dev_Poll_Reactor.h
@@ -56,52 +56,6 @@ class ACE_Dev_Poll_Reactor;
// ---------------------------------------------------------------------
-#if 0
-/**
- * @class ACE_Dev_Poll_Ready_Set
- *
- * @brief Class that contains the list of "ready" file descriptors.
- *
- * This class points to an array of pollfd structures corresponding to
- * "ready" file descriptors, such as those corresponding to event
- * handlers that request an additional callback after being initially
- * dispatched (i.e. return a value greater than zero).
- * @par
- * The idea is to store the "ready" set in an existing area of memory
- * that already contains pollfd instances. Doing so is safe since the
- * "ready" set is dispatched before polling for additional events,
- * thus avoiding being potentially overwritten during the event poll.
- * @par
- * When the "ready" set is dispatched, all that needs to be done is to
- * iterate over the contents of the array. There is no need to "walk"
- * the array in search of ready file descriptors since the array by
- * design only contains ready file descriptors. As such, this
- * implementation of a ready set is much more efficient in the
- * presence of a large number of file descriptors in terms of both
- * time and space than the one used in the Select_Reactor, for
- * example.
- */
-class ACE_Dev_Poll_Ready_Set
-{
-public:
-
- /// Constructor.
- ACE_Dev_Poll_Ready_Set (void);
-
-public:
-
- /// The array containing the pollfd structures corresponding to the
- /// "ready" file descriptors.
- struct pollfd *pfds;
-
- /// The number of "ready" file descriptors in the above array.
- int nfds;
-
-};
-#endif /* 0 */
-
-// ---------------------------------------------------------------------
-
/**
* @class ACE_Dev_Poll_Reactor_Notify
*
@@ -1050,10 +1004,6 @@ protected:
*/
ACE_HANDLE poll_fd_;
- /// Track HANDLES we are interested in for various events that must
- /// be dispatched *without* polling.
- /// ACE_Dev_Poll_Ready_Set ready_set_;
-
#if defined (ACE_HAS_EVENT_POLL)
/// Event structure to be filled by epoll_wait. epoll_wait() only gets
/// one event at a time and we rely on it's internals for fairness.
diff --git a/ACE/ace/Dev_Poll_Reactor.inl b/ACE/ace/Dev_Poll_Reactor.inl
index 84168c0d931..391de5c290d 100644
--- a/ACE/ace/Dev_Poll_Reactor.inl
+++ b/ACE/ace/Dev_Poll_Reactor.inl
@@ -1,5 +1,4 @@
// -*- C++ -*-
-//
// $Id$
#include "ace/Log_Msg.h"
@@ -20,17 +19,6 @@ ACE_Dev_Poll_Reactor::Event_Tuple::Event_Tuple (ACE_Event_Handler *eh,
// ---------------------------------------------------------------------
-#if 0
-ACE_INLINE
-ACE_Dev_Poll_Ready_Set::ACE_Dev_Poll_Ready_Set (void)
- : pfds (0),
- nfds (0)
-{
-}
-#endif /* 0 */
-
-// ---------------------------------------------------------------------
-
ACE_INLINE size_t
ACE_Dev_Poll_Reactor::Handler_Repository::size (void) const
{
diff --git a/ACE/ace/Event_Handler.h b/ACE/ace/Event_Handler.h
index 472fa3034ff..9ad36307bf1 100644
--- a/ACE/ace/Event_Handler.h
+++ b/ACE/ace/Event_Handler.h
@@ -38,7 +38,8 @@ typedef unsigned long ACE_Reactor_Mask;
/**
* @class ACE_Event_Handler
*
- * @brief Provides an abstract interface for handling various types of
+ * @brief
+ * Provides an abstract interface for handling various types of
* I/O, timer, and signal events.
*
* Subclasses read/write input/output on an I/O descriptor,
@@ -94,9 +95,9 @@ public:
// = Get/set priority
- // Priorities run from MIN_PRIORITY (which is the "lowest priority")
- // to MAX_PRIORITY (which is the "highest priority").
/// Get the priority of the Event_Handler.
+ /// @note Priorities run from MIN_PRIORITY (which is the "lowest priority")
+ /// to MAX_PRIORITY (which is the "highest priority").
virtual int priority (void) const;
/// Set the priority of the Event_Handler.
@@ -177,8 +178,8 @@ public:
* non-sockets (such as ACE_STDIN). This is commonly used in
* situations where the Reactor is used to demultiplex read events
* on ACE_STDIN on UNIX. Note that @a event_handler must be a
- * subclass of ACE_Event_Handler. If the <get_handle> method of
- * this event handler returns <ACE_INVALID_HANDLE> we default to
+ * subclass of ACE_Event_Handler. If the get_handle() method of
+ * this event handler returns ACE_INVALID_HANDLE we default to
* reading from ACE_STDIN.
*/
static ACE_THR_FUNC_RETURN read_adapter (void *event_handler);
@@ -238,7 +239,8 @@ public:
/**
* @class Reference_Counting_Policy
*
- * @brief This policy dictates the reference counting requirements
+ * @brief
+ * This policy dictates the reference counting requirements
* for the handler.
*
* This policy allows applications to configure whether it wants the
diff --git a/ACE/ace/Filecache.h b/ACE/ace/Filecache.h
index df1835b9372..f43f6ed1f76 100644
--- a/ACE/ace/Filecache.h
+++ b/ACE/ace/Filecache.h
@@ -41,7 +41,8 @@ class ACE_Filecache_Object;
/**
* @class ACE_Filecache_Handle
*
- * @brief Abstraction over a real file. This is meant to be the entry
+ * @brief
+ * Abstraction over a real file. This is meant to be the entry
* point into the Cached Virtual Filesystem.
*
* This is a cached filesystem implementation based loosely on the
@@ -143,7 +144,7 @@ private:
/// A reference to the low level instance.
ACE_Filecache_Object *file_;
- /// A <dup>'d version of the one from <file_>.
+ /// A dup'd version of the one from file_.
ACE_HANDLE handle_;
int mapit_;
@@ -157,7 +158,8 @@ typedef ACE_Hash_Map_Entry<const ACE_TCHAR *, ACE_Filecache_Object *> ACE_Fileca
/**
* @class ACE_Filecache
*
- * @brief A hash table holding the information about entry point into
+ * @brief
+ * A hash table holding the information about entry point into
* the Cached Virtual Filesystem. On insertion, the reference
* count is incremented. On destruction, reference count is
* decremented.
@@ -231,7 +233,8 @@ private:
/**
* @class ACE_Filecache_Object
*
- * @brief Abstraction over a real file. This is what the Virtual
+ * @brief
+ * Abstraction over a real file. This is what the Virtual
* Filesystem contains. This class is not intended for general
* consumption. Please consult a physician before attempting to
* use this class.
diff --git a/ACE/ace/Manual_Event.h b/ACE/ace/Manual_Event.h
index 80464fa1fc1..e83fa04ee9c 100644
--- a/ACE/ace/Manual_Event.h
+++ b/ACE/ace/Manual_Event.h
@@ -39,14 +39,14 @@ ACE_BEGIN_VERSIONED_NAMESPACE_DECL
class ACE_Export ACE_Manual_Event : public ACE_Event
{
public:
- /// constructor which will create manual event
+ /// Constructor which will create manual event
ACE_Manual_Event (int initial_state = 0,
int type = USYNC_THREAD,
const char *name = 0,
void *arg = 0);
#if defined (ACE_HAS_WCHAR)
- /// constructor which will create manual event (wchar_t version)
+ /// Constructor which will create manual event (wchar_t version)
ACE_Manual_Event (int initial_state,
int type,
const wchar_t *name,
diff --git a/ACE/ace/Map_Manager.h b/ACE/ace/Map_Manager.h
index 75c2b65f977..f18c984a5d7 100644
--- a/ACE/ace/Map_Manager.h
+++ b/ACE/ace/Map_Manager.h
@@ -111,10 +111,11 @@ class ACE_Map_Reverse_Iterator;
/**
* @class ACE_Map_Manager
*
- * @brief Define a map abstraction that associates <EXT_ID>s with
- * <INT_ID>s.
+ * @brief
+ * Define a map abstraction that associates EXT_IDs with
+ * INT_IDs.
*
- * The <EXT_ID> must support <operator==>. This constraint can
+ * The EXT_ID must support @c operator==. This constraint can
* be alleviated via template specialization, as shown in the
* $ACE_ROOT/tests/Conn_Test.cpp test.
* This class uses an ACE_Allocator to allocate memory. The
@@ -122,7 +123,7 @@ class ACE_Map_Reverse_Iterator;
* ACE_Allocator with a persistable memory pool.
* This implementation of a map uses an array, which is searched
* linearly. For more efficient searching you should use the
- * <ACE_Hash_Map_Manager>.
+ * ACE_Hash_Map_Manager.
*/
template <class EXT_ID, class INT_ID, class ACE_LOCK>
class ACE_Map_Manager
@@ -195,7 +196,7 @@ public:
/**
* Reassociate @a ext_id with @a int_id. If @a ext_id is not in the
- * map then behaves just like <bind>. Otherwise, store the old
+ * map then behaves just like bind(). Otherwise, store the old
* values of @a int_id into the "out" parameter and rebind the new
* parameters.
* @retval 0 If a new entry is bound successfully.
@@ -261,12 +262,12 @@ public:
size_t total_size (void) const;
/**
- * Returns a reference to the underlying <ACE_LOCK>. This makes it
+ * Returns a reference to the underlying ACE_LOCK. This makes it
* possible to acquire the lock explicitly, which can be useful in
* some cases if you instantiate the ACE_Atomic_Op with an
* ACE_Recursive_Mutex or ACE_Process_Mutex, or if you need to
* guard the state of an iterator.
- * @note The right name would be <lock>, but HP/C++ will choke on that!
+ * @note The right name would be lock, but HP/C++ will choke on that!
*/
ACE_LOCK &mutex (void);
diff --git a/ACE/ace/Mem_Map.h b/ACE/ace/Mem_Map.h
index 2329722c9cd..3cd7df94785 100644
--- a/ACE/ace/Mem_Map.h
+++ b/ACE/ace/Mem_Map.h
@@ -22,6 +22,7 @@
#endif /* ACE_LACKS_PRAGMA_ONCE */
#include "ace/Global_Macros.h"
+#include "ace/Copy_Disabled.h"
#include "ace/os_include/sys/os_mman.h"
#include "ace/os_include/os_limits.h"
#include "ace/os_include/os_fcntl.h"
@@ -37,7 +38,7 @@ ACE_BEGIN_VERSIONED_NAMESPACE_DECL
* This class works with both the mmap(2) UNIX system and the
* Win32 family of memory mapping system calls.
*/
-class ACE_Export ACE_Mem_Map
+class ACE_Export ACE_Mem_Map : private ACE_Copy_Disabled
{
public:
// = Initialization and termination methods.
@@ -128,38 +129,38 @@ public:
/// file.
size_t size (void) const;
- /// Unmap the region starting at <base_addr_>.
+ /// Unmap the region starting at base_addr_.
int unmap (ssize_t len = -1);
- /// Unmap the region starting at <addr_>.
+ /// Unmap the region starting at addr_.
int unmap (void *addr, ssize_t len);
/**
* Sync @a len bytes of the memory region to the backing store
- * starting at <base_addr_>. If @a len == -1 then sync the whole
+ * starting at base_addr_. If @a len == -1 then sync the whole
* region.
*/
int sync (size_t len, int flags = MS_SYNC);
/**
* Sync the whole memory region to the backing store
- * starting at <base_addr_>.
+ * starting at base_addr_.
*/
int sync (int flags = MS_SYNC);
/// Sync @a len bytes of the memory region to the backing store
- /// starting at <addr_>.
+ /// starting at addr_.
int sync (void *addr, size_t len, int flags = MS_SYNC);
/**
* Change the protection of the pages of the mapped region to @a prot
- * starting at <base_addr_> up to @a len bytes.
+ * starting at base_addr_ up to @a len bytes.
*/
int protect (size_t len, int prot = PROT_RDWR);
/**
* Change the protection of all the pages of the mapped region to @a prot
- * starting at <base_addr_>.
+ * starting at base_addr_.
*/
int protect (int prot = PROT_RDWR);
@@ -197,10 +198,6 @@ private:
ACE_OFF_T offset = 0,
LPSECURITY_ATTRIBUTES sa = 0);
- // = Disallow copying and assignment.
- ACE_Mem_Map (const ACE_Mem_Map &);
- void operator = (const ACE_Mem_Map &);
-
private:
/// Base address of the memory-mapped file.
diff --git a/ACE/ace/Message_Block.h b/ACE/ace/Message_Block.h
index 449df677d4b..c02a37d61f1 100644
--- a/ACE/ace/Message_Block.h
+++ b/ACE/ace/Message_Block.h
@@ -241,8 +241,8 @@ public:
/**
* Delete all the resources held in the message.
*
- * Note that <release()> is designed to release the continuation
- * chain; the destructor is not. See <release()> for details.
+ * @note Note that release() is designed to release the continuation
+ * chain; the destructor is not. See release() for details.
*/
virtual ~ACE_Message_Block (void);
diff --git a/ACE/ace/OS_Log_Msg_Attributes.h b/ACE/ace/OS_Log_Msg_Attributes.h
index 0360ee4ec56..33997a958b0 100644
--- a/ACE/ace/OS_Log_Msg_Attributes.h
+++ b/ACE/ace/OS_Log_Msg_Attributes.h
@@ -23,6 +23,7 @@
#include /**/ "ace/ACE_export.h"
#include "ace/os_include/os_stdio.h"
#include "ace/iosfwd.h"
+#include "ace/Copy_Disabled.h"
ACE_BEGIN_VERSIONED_NAMESPACE_DECL
@@ -39,7 +40,7 @@ ACE_BEGIN_VERSIONED_NAMESPACE_DECL
* The contents of the class must be made available to the OS layer,
* because they are part of the thread descriptor.
*/
-class ACE_Export ACE_OS_Log_Msg_Attributes
+class ACE_Export ACE_OS_Log_Msg_Attributes : private ACE_Copy_Disabled
{
public:
/// Constructor
@@ -65,16 +66,11 @@ protected:
/// Depth of the nesting for printing traces.
int trace_depth_;
-# if defined (ACE_HAS_WIN32_STRUCTURAL_EXCEPTIONS)
+#if defined (ACE_HAS_WIN32_STRUCTURAL_EXCEPTIONS)
/// Structured exception handling Callbacks, only used under Win32
ACE_SEH_EXCEPT_HANDLER seh_except_selector_;
ACE_SEH_EXCEPT_HANDLER seh_except_handler_;
-# endif /* ACE_HAS_WIN32_STRUCTURAL_EXCEPTIONS */
-
-private:
- // Prevent copying
- ACE_OS_Log_Msg_Attributes (const ACE_OS_Log_Msg_Attributes &);
- ACE_OS_Log_Msg_Attributes &operator= (const ACE_OS_Log_Msg_Attributes &);
+#endif /* ACE_HAS_WIN32_STRUCTURAL_EXCEPTIONS */
};
ACE_END_VERSIONED_NAMESPACE_DECL
diff --git a/ACE/ace/OS_NS_unistd.h b/ACE/ace/OS_NS_unistd.h
index dc718d3a40a..147ed3cf1d8 100644
--- a/ACE/ace/OS_NS_unistd.h
+++ b/ACE/ace/OS_NS_unistd.h
@@ -189,12 +189,12 @@ namespace ACE_OS
// should call gethostname()
ACE_NAMESPACE_INLINE_FUNCTION
- int hostname (char *name,
+ int hostname (char name[],
size_t maxnamelen);
#if defined (ACE_HAS_WCHAR)
ACE_NAMESPACE_INLINE_FUNCTION
- int hostname (wchar_t *name,
+ int hostname (wchar_t name[],
size_t maxnamelen);
#endif /* ACE_HAS_WCHAR */
diff --git a/ACE/ace/Object_Manager.h b/ACE/ace/Object_Manager.h
index 1e7a5845b74..d6bb30693bf 100644
--- a/ACE/ace/Object_Manager.h
+++ b/ACE/ace/Object_Manager.h
@@ -272,7 +272,7 @@ public:
static int remove_at_exit (void *object);
#if 0 /* not implemented yet */
- /// Similar to <at_exit>, except that the cleanup_hook is called
+ /// Similar to at_exit(), except that the cleanup_hook is called
/// when the current thread exits instead of when the program terminates.
static int at_thread_exit (void *object,
ACE_CLEANUP_FUNC cleanup_hook,
@@ -327,7 +327,8 @@ public:
};
/**
- * @deprecated Accesses a default signal set used, for example,
+ * @deprecated
+ * Accesses a default signal set used, for example,
* in ACE_Sig_Guard methods.
* Deprecated: use ACE_Object_Manager::default_mask () instead.
*/
@@ -411,10 +412,10 @@ public:
static void *preallocated_array[ACE_PREALLOCATED_ARRAYS];
public:
- // Application code should not use these explicitly, so they're
- // hidden here. They're public so that the ACE_Object_Manager can
- // be constructed/destructed in <main> with
- // ACE_HAS_NONSTATIC_OBJECT_MANAGER.
+ /// Application code should not use these explicitly, so they're
+ /// hidden here. They're public so that the ACE_Object_Manager can
+ /// be constructed/destructed in <main> with
+ /// ACE_HAS_NONSTATIC_OBJECT_MANAGER.
ACE_Object_Manager (void);
~ACE_Object_Manager (void);
@@ -435,7 +436,7 @@ private:
#endif /* ACE_MT_SAFE */
#if defined (ACE_HAS_TSS_EMULATION)
- // Main thread's thread-specific storage array.
+ /// Main thread's thread-specific storage array.
void *ts_storage_[ACE_TSS_Emulation::ACE_TSS_THREAD_KEYS_MAX];
bool ts_storage_initialized_;
#endif /* ACE_HAS_TSS_EMULATION */
@@ -444,7 +445,7 @@ private:
friend class ACE_Object_Manager_Manager;
#endif /* ACE_HAS_NONSTATIC_OBJECT_MANAGER */
- // Disallow copying by not implementing the following . . .
+ /// Disallow copying by not implementing the following . . .
ACE_Object_Manager (const ACE_Object_Manager &);
ACE_Object_Manager &operator= (const ACE_Object_Manager &);
};
diff --git a/ACE/ace/Recursive_Thread_Mutex.h b/ACE/ace/Recursive_Thread_Mutex.h
index 65807b64b47..19c25658c3f 100644
--- a/ACE/ace/Recursive_Thread_Mutex.h
+++ b/ACE/ace/Recursive_Thread_Mutex.h
@@ -90,14 +90,14 @@ public:
/**
* Acquire mutex ownership. This calls <acquire> and is only
- * here to make the <ACE_Recusive_Thread_Mutex> interface consistent
+ * here to make the ACE_Recusive_Thread_Mutex interface consistent
* with the other synchronization APIs.
*/
int acquire_read (void);
/**
* Acquire mutex ownership. This calls <acquire> and is only
- * here to make the <ACE_Recusive_Thread_Mutex> interface consistent
+ * here to make the ACE_Recusive_Thread_Mutex interface consistent
* with the other synchronization APIs.
*/
int acquire_write (void);
@@ -105,7 +105,7 @@ public:
/**
* Conditionally acquire mutex (i.e., won't block). This calls
* <tryacquire> and is only here to make the
- * <ACE_Recusive_Thread_Mutex> interface consistent with the other
+ * ACE_Recusive_Thread_Mutex interface consistent with the other
* synchronization APIs. Returns -1 on failure. If we "failed"
* because someone else already had the lock, @c errno is set to
* @c EBUSY.
@@ -115,7 +115,7 @@ public:
/**
* Conditionally acquire mutex (i.e., won't block). This calls
* <tryacquire> and is only here to make the
- * <ACE_Recusive_Thread_Mutex> interface consistent with the other
+ * ACE_Recusive_Thread_Mutex interface consistent with the other
* synchronization APIs. Returns -1 on failure. If we "failed"
* because someone else already had the lock, @c errno is set to
* @c EBUSY.