Correct sa findings

dlt_offline_logstorage.c
- Parameter to isdigit is not correct
- Handle the size of memset() and strncpy() properly

dlt-test-stress-user.c
- Parameter d is duplicated

dlt_env_ll.c
- Parameter env is used before NULL check
- Remove redundant line

dlt-control-common.c
dlt_daemon_event_handler.c
- Do not use NULL variable to print log

dlt_config_file_parser.c
- Remove unnecessary loop

dlt_daemon_client.c
- Return error in NULL check

dlt_user.c
- Free allocated memory in error case

Related commit: 5c8f88d logstorage: fix compile error

Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/src/offlinelogstorage/dlt_offline_logstorage.c b/src/offlinelogstorage/dlt_offline_logstorage.c
index 2a52951..872c47e 100644
--- a/src/offlinelogstorage/dlt_offline_logstorage.c
+++ b/src/offlinelogstorage/dlt_offline_logstorage.c
@@ -395,7 +395,7 @@ DLT_STATIC int dlt_logstorage_read_number(unsigned int *number, char *value)
 
     /* check if string consists of digits only */
     for (i = 0; i < len; i++)
-        if (isdigit(value[i] == 0)) {
+        if (!isdigit(value[i])) {
             dlt_log(LOG_ERR, "Invalid, is not a number \n");
             return -1;
         }