summaryrefslogtreecommitdiff
path: root/src/shared
diff options
context:
space:
mode:
authorlti9hc <114125133+lti9hc@users.noreply.github.com>2022-10-26 15:11:24 +0700
committerGitHub <noreply@github.com>2022-10-26 10:11:24 +0200
commit948ed9928d933bbbfbb704ab0cc2296cb4333055 (patch)
treed18c533ba25de25a11e6ad2779305d14d19bdfeb /src/shared
parent0f969a93770b2261b6d18b9296263f0deaf134bd (diff)
downloadDLT-daemon-948ed9928d933bbbfbb704ab0cc2296cb4333055.tar.gz
Fix for Resource and Memory Leak (#418)
dlt_daemon_client.c Adding NULL check for tok dlt_daemon_offline_logstorage.c : Adding NULL check for application dlt_user.c : Fix for Memory Leak dlt-daemon.c : Fix for Resource Leak dlt_config_file_parser.c : Add termination character at the end of string dlt_offline_trace.c : Fix for Resource Leak Signed-off-by: Mvaradaraj2 manoj.varadaraj2@harman.com Co-authored-by: Le Tin <tin.le@vn.bosch.com>
Diffstat (limited to 'src/shared')
-rw-r--r--src/shared/dlt_config_file_parser.c1
-rw-r--r--src/shared/dlt_offline_trace.c3
2 files changed, 4 insertions, 0 deletions
diff --git a/src/shared/dlt_config_file_parser.c b/src/shared/dlt_config_file_parser.c
index fc2d516..72c57ab 100644
--- a/src/shared/dlt_config_file_parser.c
+++ b/src/shared/dlt_config_file_parser.c
@@ -496,6 +496,7 @@ int dlt_config_file_get_section_name(const DltConfigFile *file,
return -1;
strncpy(name, (file->sections + num)->name, DLT_CONFIG_FILE_ENTRY_MAX_LEN);
+ name[DLT_CONFIG_FILE_ENTRY_MAX_LEN - 1] = '\0';
return 0;
}
diff --git a/src/shared/dlt_offline_trace.c b/src/shared/dlt_offline_trace.c
index 2d70a77..2b1e0df 100644
--- a/src/shared/dlt_offline_trace.c
+++ b/src/shared/dlt_offline_trace.c
@@ -296,6 +296,9 @@ int dlt_offline_trace_delete_oldest_file(DltOfflineTrace *trace)
/* go through all dlt files in directory */
DIR *dir = opendir(trace->directory);
+ if(!dir)
+ return -1;
+
while ((dp = readdir(dir)) != NULL)
if (strstr(dp->d_name, DLT_OFFLINETRACE_FILENAME_BASE)) {
int res = snprintf(filename, sizeof(filename), "%s/%s", trace->directory, dp->d_name);