| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
DLT_LOG is using internally function which are not async-signal safe (like calloc, vsnprintf). Therefore, it needs to be removed from the signal handler
Signed-off-by: Michael Methner <mmethner@de.adit-jv.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* dlt-system: Fix buffer overflow detection on 32bit targets
On 32bit target, dlt-system will termiated with error:
dlt-system: *** buffer overflow detected ***: terminated
Signed-off-by: Changqing Li <changqing.li@windriver.com>
* Fixed newline at EOF
Signed-off-by: Changqing Li <changqing.li@windriver.com>
Co-authored-by: michael-methner <mmethner@de.adit-jv.com>
|
|
|
| |
Signed-off-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com>
|
|
|
|
|
|
|
|
|
| |
when using default const string.
this location is free()'ed in the cleanup routine, leading to bugcheck upon
exit. Use strdup to allocate memory, that can be free()'ed.
Signed-off-by: Marc TITINGER <marc.titinger@non.se.com>
|
|
|
|
|
|
| |
rather self-exp: 32bits native hint will not hold 8 bits.
Signed-off-by: Marc TITINGER <marc.titinger@hotmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
In read_configuration_file() inside dlt-system-options.c memory is allocated
for saving the parsed options into config struct.
This memory is not freed again.
There are two major changes for resolving this issue:
1) Add a cleanup function inside dlt-system-options.c to free allocated memory
2) Replace all AppID and ContextID char pointer through a char array with the
lenght of DLT_ID_SIZE.
Signed-off-by: dbiastoch <dbiastoch@de.adit-jv.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
1: Move the call of pthread_sigmask in dlt-qnx-systems main before DLT_REGISTER_APP, because this already spawns a thread, what was done without applying pthread_sigmask before.
2: Replaced all threads in dlt-system, that are spawned for each feature, through one poll. This poll waits for a file descriptor event, that triggers the feature routine, that was executed before in the thread. Done this for following processes:
* reading syslog and journal
* frequently reading logfile and logprocess
* triggering filetransfer, if a file was added/changed in watched directory
* checking watchdog timer of systemd service file with defined intervall
Signed-off-by: dbiastoch <dbiastoch@de.adit-jv.com>
|
|
|
|
|
|
|
|
|
|
| |
Currently, when config IPv6 interface for dlt component,
using syslog in dlt-system can not get data from socket.
By changing struct type and interface configuration correctly,
dlt-syslog can receive log from syslog properly.
Signed-off-by: Dinh Cong Toan <toan.dinhcong@vn.bosch.com>
|
|
|
|
|
|
|
|
|
|
| |
* Fix a potential memory leak in file transfer
This potential memory leak in dlt-system-filetransfer.c can happen if only a filename
is passed to dirname(). In the current implementation of dlt-daemon, this issue cannot happen.
But in case of refactoring or different usage there is a chance that it can be triggered.
See: https://linux.die.net/man/3/dirname
Signed-off-by: Andreas Seidl <andreas.seidl@daimler.com>
|
|
|
|
|
|
|
|
| |
* New CMake option WITH_DLT_FILETRANSFER
* Only request ZLIB package if
WITH_DLT_COREDUMPHANDLER==ON or
WITH_DLT_FILETRANSFER==ON
Signed-off-by: Sebastian Kloska <sebastian.kloska@snafu.de>
|
|
|
|
|
|
| |
Since localtime() was calling tzset() internally, it should be used
before localtime_r(). Refer to man page of localtime_r() for detail.
Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
|
|
|
|
|
|
|
| |
* Don't pass a NULL pointer to localtime_r(...) and strftime(...)
* Make sure that localtime_r(...) gets a pointer to time_t
Signed-off-by: Sebastian Kloska <sebastian.kloska@daimler.com>
|
|
|
|
|
|
|
|
|
|
| |
* Replace all start_XXX functions with one start_thread
* Don't make pthread_t static
* Don't use pthread_attr_t. Simply pass NULL
* Bail out when pthread_create() fails
* Check if MAX_THREADS gets exceeded
Signed-off-by: Sebastian Kloska <sebastian.kloska@daimler.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two new macros are introduced so that users can use their customized
timestamps for DLT messages:
- DLT_LOG_TS(CONTEXT, LOGLEVEL, TS, ARGS ...)
- DLT_LOG_ID_TS(CONTEXT, LOGLEVEL, MSGID, TS, ARGS ...)
Detailed explanations can be found in dlt_for_developers.md.
Also a new option is added to dlt-system to use events' timestamps
from journald adapter.
Signed-off-by: Sebastian Unger <sunger@de.adit-jv.com>
|
|
|
|
|
|
|
| |
fixes compiler error
"error: too many arguments to function ‘localtime’"
Signed-off-by: jiripopek <Jiri.Popek@bmw.de>
|
|
|
|
| |
Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
|
|
|
|
| |
Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix compiler warnings about socket usage
Correct the data types used for the socket declaration. We use AF_UNIX
sockets so we use struct sockaddr_un, but we need to cast to struct
sockaddr for the socket API.
Fix compiler warnings about sign-compare
Fix two occurences of signed - unsigned comparison by casting the values
accordingly. Note that the cast is legal as the first parts of both
conditional statements make sure the value is not negative before
casting to unsigned.
While at it, add strtol error checking.
Fix compiler warnings about string functions
Add string.h to src/daemon/dlt_daemon_unix_socket.c, because it was
unaware of memcpy and strerror. While at it, change unsafe use of
sprintf to proper dlt_vlog and remove the char buffer.
Fix compiler warnings about unused-*
Fix two unused-variable and one unused-parameter warning. While at it,
change the #ifdef to not run into an empty block. Simply reverse the
condition and enclose the complete else with the #ifdef.
POSIX: Use memset instead of bzero
"The bzero() function is deprecated (marked as LEGACY in POSIX.1-2001);
use memset(3) in new programs."
Use memset instead of bzero and remove any occurrence from DLT. Include
of header "strings.h" that has bzero is also removed.
Signed-off-by: Simon Herkenhoff <sherkenhoff@jp.adit-jv.com>
Signed-off-by: ManikandanC <Manikandan.Chockalingam@in.bosch.com>
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@de.adit-jv.com>
|
|
|
|
|
|
|
|
|
|
|
| |
In function ‘daemonize’:
dlt-daemon/src/system/dlt-system-process-handling.c:84:5: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for(i = getdtablesize(); i >= 0; i--)
^~~
dlt-daemon/src/system/dlt-system-process-handling.c:87:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’
int fd = open("/dev/null",O_RDWR);
^~~
Singed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
|
|
|
|
|
|
|
|
|
|
| |
Added additional information about how to enable syslog feature properly.
If still facing issue while capturing syslogs through client (e.g. dlt_viewer) after following given steps then install listed packages:
build-essential
build-essential checkinstall
pkg-config libsystemd-journal-dev
Note:
It's is a known issue when you try to capture syslog via dlt_viewer then syslogs wouldn't come in dlt_viewer because of improper configuration (won't route the log to port 47111) of dlt-system.
|
|
|
|
|
|
|
| |
Remove malloc assert in inappropriate location and add error logs in case of
failures.
Signed-off-by: Manikandan C <Manikandan.Chockalingam@in.bosch.com>
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
|
| |
Output debug log: File name contained in inotify event message.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I276b1373ae3b60347b4af44681f5c601f62dde4c
|
|
|
|
|
|
|
|
| |
Currently, dlt-system just wait for free space of user buffer > 50%.
To speed up the file transfer, dlt-system should try to resend user buffer contents actively.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I09d76acacf65b2c68559a05d45e00f35f402316a
|
|
|
|
|
|
|
|
| |
When file transfer feature of dlt-system is used on the 64 bit OS, file name is overwritten at the unique name creation phase.
File serial number should be maximum 10-digit decimal number.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I18fac363a103b6806ed9eb003ebbb305af7e7f58
|
|
|
|
|
|
|
|
|
|
|
| |
If a file get written to after it appeared in a folder that is watched
by the dlt-system filetransfer thread, the application tries to send
this file multiple times, causing it to crash. This patch fixes this by
canceling the sending process more gracefully if the file cannot be
found.
Change-Id: Id19b72061bed41642d12cd33afeaa41fb444b2c8
Signed-off-by: Lutz Helwing <lutz_helwing@mentor.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each file that is supposed to be sent, dlt-system will check if a
client is connected to the daemon. If not, it waits and keeps checking
once per second, until a client is connected.
Files will still be compressed and moved to the .tosend subdirectory,
regardless of the client connection.
Changed the default startup timeout in the configuration file to 0.
Change-Id: I5850adb51c381bc6279ac59f5bd985491ba5caf3
Signed-off-by: Lutz Helwing <lutz_helwing@mentor.com>
|
|
|
|
|
|
|
|
| |
- feature: allow to define a default-log-level in dlt.conf (see dlt.conf for documentation)
- bugfix: make dlt_unlock_mutex not inline to fix linkage
- bugfix: initial log-level was not set correctly when no dlt-daemon was running
Signed-off-by: Stefan Vacek <stefan.vacek@intel.com>
|
|
|
|
|
|
|
|
| |
Additional:
- include sd-daemon.h if watchdog is enabled
- fix formatting for printf 64bit values
Signed-off-by: Stefan Vacek <stefan.vacek@intel.com>
|
|
|
|
| |
replacing llu with PRIu64
|
|
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
Signed-off-by: S. Hameed <shameed@jp.adit-jv.com>
|
|
|
|
|
|
| |
version >= 209
Signed-off-by: Lutz Helwing <lutz_helwing@mentor.com>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
|
|
| |
use _SOURCE_REALTIME_TIMESTAMP if available, else fall back to __REALTIME_TIMESTAMP which is always present Monotonic time: use _SOURCE_MONOTONIC_TIMESTAMP if available, else fall back to __MONOTONIC_TIMESTAMP which is always present
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
|
|
| |
Scan findings. Renamed and cleanup further files.
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
|
|
| |
location (not only "/usr").
Signed-off-by: Jacques GUILLOU <jacques.guillou@pelagicore.com>
|
|
|
|
|
|
|
| |
Enables communication between DLT server and clients over IPv6.
Signed-off-by: Jiri Popek <jiri.popek@bmw.de>
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
|
|
| |
user PREFIX (e.g. /temp/test_with_pref). PREFIX Fix for filetransfer directory (PREFIX/share/).
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
|
|
| |
lib dll to correct location on Windows. Originally from Mikko Rapeli <mikko.rapeli@bmw.de>.
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
|
|
| |
implementation
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
|