diff options
| author | Thomas Haller <thaller@redhat.com> | 2020-11-09 09:34:49 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2020-11-09 09:35:59 +0100 |
| commit | 52c689153414f5cf236d4947f2561ba9f90b5e4c (patch) | |
| tree | f044032414cd2fb9b21315edd381de13aa8f2edf /.gitlab-ci/ci.template | |
| parent | 35334f478bdb9e691122f041d07b337b1440a760 (diff) | |
| download | NetworkManager-52c689153414f5cf236d4947f2561ba9f90b5e4c.tar.gz | |
gitlab-ci: reorder jobs for checkpatch test
All the steps of "checkpatch" test (except the last) check
the current tree for consistency. Those checks must always
pass.
Only the last step calls the "checkpatch-feature-branch.sh".
That script checks for common patterns, like avoiding g_assert()
(in favor of other assertion types). That last check only checks
the current patch, and there are many cases where the test is
known to fail (because these are just heuristics). As such, the
step that may fail should be called as last.
Diffstat (limited to '.gitlab-ci/ci.template')
| -rw-r--r-- | .gitlab-ci/ci.template | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.gitlab-ci/ci.template b/.gitlab-ci/ci.template index 9f67dd7891..be4f651588 100644 --- a/.gitlab-ci/ci.template +++ b/.gitlab-ci/ci.template @@ -199,10 +199,10 @@ checkpatch: stage: test script: - date '+%Y%m%d-%H%M%S'; dnf install -y git black gettext /usr/bin/xargs which clang - - date '+%Y%m%d-%H%M%S'; NM_CHECKPATCH_FETCH_UPSTREAM=1 contrib/scripts/checkpatch-feature-branch.sh - date '+%Y%m%d-%H%M%S'; black --check . examples/python/gi/nm-wg-set - date '+%Y%m%d-%H%M%S'; git ls-files -z -- 'po/*.po' | xargs -0 -n1 msgfmt -vc - date '+%Y%m%d-%H%M%S'; contrib/scripts/nm-code-format.sh + - date '+%Y%m%d-%H%M%S'; NM_CHECKPATCH_FETCH_UPSTREAM=1 contrib/scripts/checkpatch-feature-branch.sh allow_failure: true pages: |