diff options
| author | Francesco Giudici <fgiudici@redhat.com> | 2017-04-03 12:41:55 +0200 |
|---|---|---|
| committer | Francesco Giudici <fgiudici@redhat.com> | 2017-04-05 15:55:04 +0200 |
| commit | 512ed904c61418332633c7ed3da03777bdc269a1 (patch) | |
| tree | 792da9adf103d7e40110e66c303bae08d671df08 | |
| parent | 6a3d77fbe6271bb632e5272ef49c58e30739c38e (diff) | |
| download | NetworkManager-fg/nmcli_options.tar.gz | |
nmcli: fix 'nmcli con export' parameters checkfg/nmcli_options
get_connection() will already move forward arguments (argc/argv):
remove extra argv++/argc--
Example:
"nmcli con export <vpn_con> <output_file> <extra_arg>"
now, extra_arg is detected, printing error:
"Error: unknown extra argument: 'extra_arg'."
| -rw-r--r-- | clients/cli/connections.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/clients/cli/connections.c b/clients/cli/connections.c index 5bca138893..630cefb303 100644 --- a/clients/cli/connections.c +++ b/clients/cli/connections.c @@ -8786,11 +8786,7 @@ do_connection_export (NmCli *nmc, int argc, char **argv) if (nmc->complete) return nmc->return_value; - if (argc) { - out_name = *argv; - argc--; - argv++; - } + out_name = *argv; if (next_arg (nmc->ask ? NULL : nmc, argc_ptr, argv_ptr, NULL) == 0) { g_string_printf (nmc->return_text, _("Error: unknown extra argument: '%s'."), *argv); |