diff options
| author | Thomas Haller <thaller@redhat.com> | 2023-05-02 11:37:27 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2023-05-02 11:42:49 +0200 |
| commit | 4ddbf32f1bcc181b6e6a953bfcdfc39121692aa9 (patch) | |
| tree | 493e0ae86909c16f6bafc2c0f111cd6b77755a8f | |
| parent | 601605dbea6ef68553e50b4ad609e28edbf9f142 (diff) | |
| download | NetworkManager-4ddbf32f1bcc181b6e6a953bfcdfc39121692aa9.tar.gz | |
dns/trivial: rename check_public_suffix parameter of domain_is_valid()
Names are important. The previous name was counter intuitive for what
the behavior was.
| -rw-r--r-- | src/core/dns/nm-dns-manager.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/core/dns/nm-dns-manager.c b/src/core/dns/nm-dns-manager.c index 34c561e323..56c91aaa37 100644 --- a/src/core/dns/nm-dns-manager.c +++ b/src/core/dns/nm-dns-manager.c @@ -173,7 +173,9 @@ NM_DEFINE_SINGLETON_GETTER(NMDnsManager, nm_dns_manager_get, NM_TYPE_DNS_MANAGER /*****************************************************************************/ static gboolean -domain_is_valid(const char *domain, gboolean check_public_suffix, gboolean assume_any_tld_is_public) +domain_is_valid(const char *domain, + gboolean reject_public_suffix, + gboolean assume_any_tld_is_public) { #if WITH_LIBPSL /* ifdef to fall back to old API function on platforms with older LIBPSL */ @@ -202,10 +204,10 @@ domain_is_valid(const char *domain, gboolean check_public_suffix, gboolean assum */ if (!assume_any_tld_is_public) type = PSL_TYPE_NO_STAR_RULE; - if (check_public_suffix && psl_is_public_suffix2(psl_builtin(), domain, type)) + if (reject_public_suffix && psl_is_public_suffix2(psl_builtin(), domain, type)) return FALSE; #else - if (check_public_suffix && psl_is_public_suffix(psl_builtin(), domain)) + if (reject_public_suffix && psl_is_public_suffix(psl_builtin(), domain)) return FALSE; #endif #endif |