summaryrefslogtreecommitdiff
path: root/src/n-acd
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2021-09-30 15:02:13 +0200
committerThomas Haller <thaller@redhat.com>2021-09-30 15:10:17 +0200
commit6837095aab9aa8ce92ed1defca44b46960658714 (patch)
treedecc3674e72a4c91af88307f97ef3413963e2fdc /src/n-acd
parente989cbbd99ee07d10fa4909c294997b75ae0bed4 (diff)
downloadNetworkManager-6837095aab9aa8ce92ed1defca44b46960658714.tar.gz
n-acd: fix handling of N_ACD_E_DROPPED
N_ACD_E_DROPPED is an error code of n-acd, albeit internal. But such codes are returned as postive values, unlike error codes from errno.h (which are negative). Fix comparing for N_ACD_E_DROPPED, otherwise the error gets propagate to the caller when we should handle it internally.
Diffstat (limited to 'src/n-acd')
-rw-r--r--src/n-acd/src/n-acd-probe.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/n-acd/src/n-acd-probe.c b/src/n-acd/src/n-acd-probe.c
index 2a5c645192..c1ed59ae9e 100644
--- a/src/n-acd/src/n-acd-probe.c
+++ b/src/n-acd/src/n-acd-probe.c
@@ -420,7 +420,7 @@ int n_acd_probe_handle_timeout(NAcdProbe *probe) {
r = n_acd_send(probe->acd, &probe->ip, NULL);
if (r) {
- if (r != -N_ACD_E_DROPPED)
+ if (r != N_ACD_E_DROPPED)
return r;
/*
@@ -475,7 +475,7 @@ int n_acd_probe_handle_timeout(NAcdProbe *probe) {
r = n_acd_send(probe->acd, &probe->ip, &probe->ip);
if (r) {
- if (r != -N_ACD_E_DROPPED)
+ if (r != N_ACD_E_DROPPED)
return r;
/*
@@ -595,7 +595,7 @@ int n_acd_probe_handle_packet(NAcdProbe *probe, struct ether_arp *packet, bool h
if (!rate_limited) {
r = n_acd_send(probe->acd, &probe->ip, &probe->ip);
if (r) {
- if (r != -N_ACD_E_DROPPED)
+ if (r != N_ACD_E_DROPPED)
return r;
if (probe->defend == N_ACD_DEFEND_ONCE) {
@@ -604,7 +604,7 @@ int n_acd_probe_handle_packet(NAcdProbe *probe, struct ether_arp *packet, bool h
}
}
- if (r != -N_ACD_E_DROPPED)
+ if (r != N_ACD_E_DROPPED)
probe->last_defend = now;
}