diff options
author | Beniamino Galvani <bgalvani@redhat.com> | 2019-11-21 18:05:11 +0100 |
---|---|---|
committer | Beniamino Galvani <bgalvani@redhat.com> | 2019-11-25 08:58:27 +0100 |
commit | a73efb059f5ffdcc200ec30c443d06b6d656fcfe (patch) | |
tree | 1424aa46d7446ab0bd6dbce15b2772549d15b523 /src/nm-manager.h | |
parent | 0521e06ff13fa614f7da869aac0058b7dd31190a (diff) | |
download | NetworkManager-a73efb059f5ffdcc200ec30c443d06b6d656fcfe.tar.gz |
manager: don't activate device if the parent is missing
In multiple places we currently proceed to creating a virtual device
even if the connection specifies a parent device which is
missing. This can be easily reproduced with:
nmcli con add type vxlan ifname vxlan1 \
vxlan.parent not-exists \
id 43 remote 172.25.1.1
which creates a vxlan1 interface without activating any
connection. Add a check to prevent this.
https://bugzilla.redhat.com/show_bug.cgi?id=1774074
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/344
Diffstat (limited to 'src/nm-manager.h')
-rw-r--r-- | src/nm-manager.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/nm-manager.h b/src/nm-manager.h index 1c71736bcd..ad06e318f4 100644 --- a/src/nm-manager.h +++ b/src/nm-manager.h @@ -149,6 +149,7 @@ void nm_manager_device_route_metric_clear (NMManager *self, char * nm_manager_get_connection_iface (NMManager *self, NMConnection *connection, NMDevice **out_parent, + const char **out_parent_spec, GError **error); const char * nm_manager_iface_for_uuid (NMManager *self, |