summaryrefslogtreecommitdiff
path: root/src/settings/nm-agent-manager.c
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2016-02-28 16:25:36 +0100
committerThomas Haller <thaller@redhat.com>2016-03-03 18:54:20 +0100
commit01b9b4104c365002fae5e45b564956062fe146d4 (patch)
treede72d05b95706d94a8750d9870768b61edf8b98a /src/settings/nm-agent-manager.c
parent7871d850f50975b46f7909bc6bd3cce434c7c60e (diff)
downloadNetworkManager-01b9b4104c365002fae5e45b564956062fe146d4.tar.gz
all: clean-up usage of GError
Functions that take a GError** MUST fill it in on error. There is no need to check whether error is NULL if the function it was passed to had a failing return value. Likewise, a proper GError must have a non-NULL message, so there's no need to double-check that either. Based-on-patch-by: Dan Winship <danw@gnome.org>
Diffstat (limited to 'src/settings/nm-agent-manager.c')
-rw-r--r--src/settings/nm-agent-manager.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/settings/nm-agent-manager.c b/src/settings/nm-agent-manager.c
index bc09e03167..a165f87fcd 100644
--- a/src/settings/nm-agent-manager.c
+++ b/src/settings/nm-agent-manager.c
@@ -989,7 +989,7 @@ _con_get_request_start_validated (NMAuthChain *chain,
if (error) {
_LOGD (req->current, "agent "LOG_REQ_FMT" MODIFY check error: (%d) %s",
LOG_REQ_ARG (req),
- error->code, error->message ? error->message : "(unknown)");
+ error->code, error->message);
/* Try the next agent */
request_next_agent (req);
} else {