summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRay Strode <rstrode@redhat.com>2019-05-09 14:58:34 -0400
committerRay Strode <rstrode@redhat.com>2019-05-09 14:58:34 -0400
commit64b11314ea71b5e22edf4d968347489c5d5acd01 (patch)
tree49c9cbfa54059d4b99f81d99d666605292f88c3b
parent0e712e935abd26499ff5995ab363e5bfd9ee7c4c (diff)
downloadaccountsservice-fix-wtmp-memory-fragmentation.tar.gz
data: don't send change updates for login-historyfix-wtmp-memory-fragmentation
The login-history property of user objects can be quite large. If wtmp is changed frequently, that can lead to memory fragmentation in clients. Furthermore, most clients never check login-history, so it's wasted memory and wasted cpu. This commit disables change notification for that property. If a client really needs to get updates, they can manually refresh their cache when appropriate.
-rw-r--r--data/org.freedesktop.Accounts.User.xml1
1 files changed, 1 insertions, 0 deletions
diff --git a/data/org.freedesktop.Accounts.User.xml b/data/org.freedesktop.Accounts.User.xml
index 8d3fe1c..3b839a3 100644
--- a/data/org.freedesktop.Accounts.User.xml
+++ b/data/org.freedesktop.Accounts.User.xml
@@ -812,6 +812,7 @@
</property>
<property name="LoginHistory" type="a(xxa{sv})" access="read">
+ <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>
<doc:doc>
<doc:description>
<doc:para>