diff options
author | Robert Moore <Robert.Moore@intel.com> | 2019-08-21 09:23:50 -0700 |
---|---|---|
committer | Robert Moore <Robert.Moore@intel.com> | 2019-08-21 09:23:50 -0700 |
commit | 1f08279b3eb13f17004159c28c391a390cd68feb (patch) | |
tree | bf24988f99b8c450ae4ade29febbd52377910e6f /source/components/events | |
parent | e92bd9211174397c87261160f321fa66f195fe73 (diff) | |
download | acpica-1f08279b3eb13f17004159c28c391a390cd68feb.tar.gz |
Results from Clang changes/fixes
From Clang V5.0.1. Mostly "set but never read" warnings.
Diffstat (limited to 'source/components/events')
-rw-r--r-- | source/components/events/evgpeblk.c | 6 | ||||
-rw-r--r-- | source/components/events/evgpeinit.c | 3 | ||||
-rw-r--r-- | source/components/events/evmisc.c | 17 | ||||
-rw-r--r-- | source/components/events/evregion.c | 4 | ||||
-rw-r--r-- | source/components/events/evrgnini.c | 1 |
5 files changed, 21 insertions, 10 deletions
diff --git a/source/components/events/evgpeblk.c b/source/components/events/evgpeblk.c index 80157dcd3..e0e2780f3 100644 --- a/source/components/events/evgpeblk.c +++ b/source/components/events/evgpeblk.c @@ -272,6 +272,10 @@ AcpiEvDeleteGpeBlock ( /* Disable all GPEs in this block */ Status = AcpiHwDisableGpeBlock (GpeBlock->XruptBlock, GpeBlock, NULL); + if (ACPI_FAILURE (Status)) + { + return_ACPI_STATUS (Status); + } if (!GpeBlock->Previous && !GpeBlock->Next) { @@ -542,7 +546,7 @@ AcpiEvCreateGpeBlock ( WalkInfo.GpeDevice = GpeDevice; WalkInfo.ExecuteByOwnerId = FALSE; - Status = AcpiNsWalkNamespace (ACPI_TYPE_METHOD, GpeDevice, + (void) AcpiNsWalkNamespace (ACPI_TYPE_METHOD, GpeDevice, ACPI_UINT32_MAX, ACPI_NS_WALK_NO_UNLOCK, AcpiEvMatchGpeMethod, NULL, &WalkInfo, NULL); diff --git a/source/components/events/evgpeinit.c b/source/components/events/evgpeinit.c index b7e02a060..7e3c766c6 100644 --- a/source/components/events/evgpeinit.c +++ b/source/components/events/evgpeinit.c @@ -302,8 +302,6 @@ AcpiEvGpeInitialize ( * GPE0 and GPE1 do not have to be contiguous in the GPE number * space. However, GPE0 always starts at GPE number zero. */ - GpeNumberMax = AcpiGbl_FADT.Gpe1Base + - ((RegisterCount1 * ACPI_GPE_REGISTER_WIDTH) - 1); } } @@ -315,7 +313,6 @@ AcpiEvGpeInitialize ( ACPI_DEBUG_PRINT ((ACPI_DB_INIT, "There are no GPE blocks defined in the FADT\n")); - Status = AE_OK; goto Cleanup; } diff --git a/source/components/events/evmisc.c b/source/components/events/evmisc.c index f73cc2f3c..68f1dc8a3 100644 --- a/source/components/events/evmisc.c +++ b/source/components/events/evmisc.c @@ -400,11 +400,16 @@ AcpiEvTerminate ( /* Disable all GPEs in all GPE blocks */ Status = AcpiEvWalkGpeList (AcpiHwDisableGpeBlock, NULL); + if (ACPI_FAILURE (Status)) + { + ACPI_EXCEPTION ((AE_INFO, Status, + "Could not disable GPEs in GPE block")); + } Status = AcpiEvRemoveGlobalLockHandler (); - if (ACPI_FAILURE(Status)) + if (ACPI_FAILURE (Status)) { - ACPI_ERROR ((AE_INFO, + ACPI_EXCEPTION ((AE_INFO, Status, "Could not remove Global Lock handler")); } @@ -414,7 +419,7 @@ AcpiEvTerminate ( /* Remove SCI handlers */ Status = AcpiEvRemoveAllSciHandlers (); - if (ACPI_FAILURE(Status)) + if (ACPI_FAILURE (Status)) { ACPI_ERROR ((AE_INFO, "Could not remove SCI handler")); @@ -423,6 +428,12 @@ AcpiEvTerminate ( /* Deallocate all handler objects installed within GPE info structs */ Status = AcpiEvWalkGpeList (AcpiEvDeleteGpeHandlers, NULL); + if (ACPI_FAILURE (Status)) + { + ACPI_EXCEPTION ((AE_INFO, Status, + "Could not delete GPE handlers")); + } + /* Return to original mode if necessary */ diff --git a/source/components/events/evregion.c b/source/components/events/evregion.c index 6f6d7ccc8..13a20918c 100644 --- a/source/components/events/evregion.c +++ b/source/components/events/evregion.c @@ -1037,11 +1037,11 @@ AcpiEvOrphanEcRegMethod ( Objects[1].Type = ACPI_TYPE_INTEGER; Objects[1].Integer.Value = ACPI_REG_CONNECT; - Status = AcpiEvaluateObject (RegMethod, NULL, &Args, NULL); + (void) AcpiEvaluateObject (RegMethod, NULL, &Args, NULL); Exit: /* We ignore all errors from above, don't care */ - Status = AcpiUtAcquireMutex (ACPI_MTX_NAMESPACE); + (void) AcpiUtAcquireMutex (ACPI_MTX_NAMESPACE); return_VOID; } diff --git a/source/components/events/evrgnini.c b/source/components/events/evrgnini.c index 718e2e87d..3c865c59f 100644 --- a/source/components/events/evrgnini.c +++ b/source/components/events/evrgnini.c @@ -363,7 +363,6 @@ AcpiEvPciConfigRegionSetup ( * root bridge. Still need to return a context object * for the new PCI_Config operation region, however. */ - Status = AE_OK; } else { |