diff options
| author | Dan Keder <dan.keder@gmail.com> | 2015-05-27 16:30:49 +0200 |
|---|---|---|
| committer | Dan Keder <dan.keder@gmail.com> | 2015-05-27 16:30:49 +0200 |
| commit | 9fe9f6e7e6fb66bbe70dcd4b1ab516751f7cbddd (patch) | |
| tree | a7076263fd650e8e560bc6328c2d01a5bf494a18 /system | |
| parent | 504bf832b47c24e05197297753b0c069ccc04478 (diff) | |
| download | ansible-modules-extras-9fe9f6e7e6fb66bbe70dcd4b1ab516751f7cbddd.tar.gz | |
seport.py: fix the "change" indication
Diffstat (limited to 'system')
| -rw-r--r-- | system/seport.py | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/system/seport.py b/system/seport.py index 3d6cb617..c264334a 100644 --- a/system/seport.py +++ b/system/seport.py @@ -134,10 +134,12 @@ def semanage_port_add(module, ports, proto, setype, do_reload, serange='s0', ses try: seport = seobject.portRecords(sestore) seport.set_reload(do_reload) + change = False for port in ports: - change = not semanage_port_exists(seport, port, proto) - if change and not module.check_mode: + exists = semanage_port_exists(seport, port, proto) + if not exists and not module.check_mode: seport.add(port, proto, serange, setype) + change = change or not exists except ValueError as e: module.fail_json(msg="%s: %s\n" % (e.__class__.__name__, str(e))) @@ -177,10 +179,12 @@ def semanage_port_del(module, ports, proto, do_reload, sestore=''): try: seport = seobject.portRecords(sestore) seport.set_reload(do_reload) + change = False for port in ports: - change = not semanage_port_exists(seport, port, proto) - if change and not module.check_mode: + exists = semanage_port_exists(seport, port, proto) + if not exists and not module.check_mode: seport.delete(port, proto) + change = change or not exists except ValueError as e: module.fail_json(msg="%s: %s\n" % (e.__class__.__name__, str(e))) |