diff options
| author | Ryan S. Brown <sb@ryansb.com> | 2017-11-07 09:30:47 -0500 |
|---|---|---|
| committer | Ryan S. Brown <sb@ryansb.com> | 2017-11-07 09:55:26 -0500 |
| commit | e9b5e14764d9ee713c0d29dd08e92746fe9f6187 (patch) | |
| tree | aced5db8b97e14249bb53a877c9536888a7026da | |
| parent | f9e16d7072d7c77648cb70bb28bc65ea19dac6d5 (diff) | |
| download | ansible-e9b5e14764d9ee713c0d29dd08e92746fe9f6187.tar.gz | |
[cloud] sns_topic: Fix unreferenced variable
Cherry-pick of 4e759a9cced30401301530f7f5b3ffefbb58b9db
| -rw-r--r-- | CHANGELOG.md | 2 | ||||
| -rw-r--r-- | lib/ansible/modules/cloud/amazon/sns_topic.py | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index c7c97e3c03..e0493b4961 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -138,6 +138,8 @@ Ansible Changes By Release (https://github.com/ansible/ansible/pull/32203) * Fix for validating proxy results on Python3 for modules making http requests: (https://github.com/ansible/ansible/pull/32596) +* Fix unreferenced variable in SNS topic module + (https://github.com/ansible/ansible/pull/29117) <a id="2.4.1"></a> diff --git a/lib/ansible/modules/cloud/amazon/sns_topic.py b/lib/ansible/modules/cloud/amazon/sns_topic.py index 7c8385c7f6..e0e3ae6a52 100644 --- a/lib/ansible/modules/cloud/amazon/sns_topic.py +++ b/lib/ansible/modules/cloud/amazon/sns_topic.py @@ -280,7 +280,7 @@ class SnsTopicManager(object): for (protocol, endpoint) in desired_subscriptions: if (protocol, endpoint) not in subscriptions_existing_list: self.changed = True - self.subscriptions_added.append(sub) + self.subscriptions_added.append((protocol, endpoint)) if not self.check_mode: self.connection.subscribe(self.arn_topic, protocol, endpoint) |