eos_acls : Add eos acls resource module (#66308)

* Adding files for RM static_routes

* Added Integration tests

* Added Unit testcases

* Addressed review comments

* corrected lint errors

* corrected documentation errors

* Lint errors

* corrected test/sanity

* corrected documentation for deprecation

* corrected case sensitivity

* Again Documentation eroor

* Lint errors again

* corrected deprecated module in ignoretxt

* added new gethered,rendered,parsed state checks to unit test

* New code broke the old flow-fixed

* Lint errs

* Added check for running_config

* eos_acls resource module added

* Corrected errors

* corrected documentation errors

* corrected typo

* Testcases in progress

* Integration tests in progress

* Integration tests

* Added Intergration tcs

* Corrected pylint errors

* Resolving issues due to rebase

* Corrected Typo

* more pylint errors

* more pylint errors

* more pylint errors

* Documentation

* Documentation

* More lint errors

* Fixed Indentation

* Indentation issues - not getting fixed

* Indentation issues - not getting fixed

* Added rtt testcase

* Corrected whitespaces

* addressed review comments

* moved integration tests to common - to support eapi tests

* modification for merge update

* indentation errors

* added line key

* Fixing shippable errors

* fixing doc errors

* fixing doc errors

* fixing doc errors

* fixing doc errors

* fixing indentation

* modified replaced operation

* rebase issue fixed

* Corrected typo

* review comments and flake8 error fixed

3 files changed, 282 insertions, 2 deletions

diff --git a/test/units/modules/network/eos/eos_module.py b/test/units/modules/network/eos/eos_module.py
index 12f84af41a..ddc92b0497 100644
--- a/test/units/modules/network/eos/eos_module.py
+++ b/test/units/modules/network/eos/eos_module.py
@@ -23,6 +23,7 @@ import json
 import os
 
 from units.modules.utils import AnsibleExitJson, AnsibleFailJson, ModuleTestCase
+from ansible.module_utils.network.common.utils import dict_diff, param_list_to_dict
 
 
 fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
@@ -37,7 +38,6 @@ def load_fixture(name):
 
     with open(path) as f:
         data = f.read()
-
     try:
         data = json.loads(data)
     except Exception:
@@ -62,7 +62,6 @@ class TestEosModule(ModuleTestCase):
         else:
             result = self.changed(changed)
             self.assertEqual(result['changed'], changed, result)
-
         if commands is not None:
             if transport == 'eapi':
                 cmd = []
diff --git a/test/units/modules/network/eos/fixtures/eos_acls_config.cfg b/test/units/modules/network/eos/fixtures/eos_acls_config.cfg
new file mode 100644
index 0000000000..fa4e4aae57
--- /dev/null
+++ b/test/units/modules/network/eos/fixtures/eos_acls_config.cfg
@@ -0,0 +1,3 @@
+ip access-list test1
+   35 deny tcp 20.0.0.0/8 any log 
+   45 permit tcp any any
diff --git a/test/units/modules/network/eos/test_eos_acls.py b/test/units/modules/network/eos/test_eos_acls.py
new file mode 100644
index 0000000000..6a0947d2d2
--- /dev/null
+++ b/test/units/modules/network/eos/test_eos_acls.py
@@ -0,0 +1,278 @@
+#
+# (c) 2019, Ansible by Red Hat, inc
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+#
+
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+from units.compat.mock import patch
+from ansible.modules.network.eos import eos_acls
+from ansible.module_utils.network.eos.config.acls.acls import add_commands
+from units.modules.utils import set_module_args
+from .eos_module import TestEosModule, load_fixture
+import itertools
+
+
+class TestEosAclsModule(TestEosModule):
+    module = eos_acls
+
+    def setUp(self):
+        super(TestEosAclsModule, self).setUp()
+
+        self.mock_get_config = patch(
+            'ansible.module_utils.network.common.network.Config.get_config')
+        self.get_config = self.mock_get_config.start()
+
+        self.mock_load_config = patch(
+            'ansible.module_utils.network.common.network.Config.load_config')
+        self.load_config = self.mock_load_config.start()
+
+        self.mock_get_resource_connection_config = patch(
+            'ansible.module_utils.network.common.cfg.base.get_resource_connection'
+        )
+        self.get_resource_connection_config = self.mock_get_resource_connection_config.start(
+        )
+
+        self.mock_get_resource_connection_facts = patch(
+            'ansible.module_utils.network.common.facts.facts.get_resource_connection'
+        )
+        self.get_resource_connection_facts = self.mock_get_resource_connection_facts.start(
+        )
+
+        self.mock_edit_config = patch(
+            'ansible.module_utils.network.eos.providers.providers.CliProvider.edit_config'
+        )
+        self.edit_config = self.mock_edit_config.start()
+
+        self.mock_execute_show_command = patch(
+            'ansible.module_utils.network.eos.facts.acls.acls.AclsFacts.get_device_data'
+        )
+        self.execute_show_command = self.mock_execute_show_command.start()
+
+    def tearDown(self):
+        super(TestEosAclsModule, self).tearDown()
+        self.mock_get_resource_connection_config.stop()
+        self.mock_get_resource_connection_facts.stop()
+        self.mock_edit_config.stop()
+        self.mock_get_config.stop()
+        self.mock_load_config.stop()
+        self.mock_execute_show_command.stop()
+
+    def load_fixtures(self, commands=None, transport='cli', filename=None):
+        if filename is None:
+            filename = 'eos_acls_config.cfg'
+
+        def load_from_file(*args, **kwargs):
+            output = load_fixture(filename)
+            return output
+
+        self.execute_show_command.side_effect = load_from_file
+
+    def test_eos_acls_merged(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv6",
+                     acls=[
+                         dict(name="test2",
+                              standard="true",
+                              aces=[
+                                  dict(sequence="10",
+                                       grant="permit",
+                                       protocol="ospf",
+                                       source=dict(subnet_address="30.2.0.0/8"),
+                                       destination=dict(any="true"),
+                                       log="true")
+                              ])
+                     ])
+            ], state="merged"))
+        commands = ['ipv6 access-list standard test2', '10 permit ospf 30.2.0.0/8 any log']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_eos_acls_merged_idempotent(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1",
+                              aces=[
+                                  dict(sequence="35",
+                                       grant="deny",
+                                       protocol="tcp",
+                                       source=dict(subnet_address="20.0.0.0/8"),
+                                       destination=dict(any="true"),
+                                       log="true"),
+                                  dict(grant="permit",
+                                       source=dict(any="true"),
+                                       destination=dict(any="true"),
+                                       protocol=6)
+                              ])
+                     ])
+            ], state="merged"))
+        self.execute_module(changed=False, commands=[])
+
+    def test_eos_acls_replaced(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1",
+                              aces=[
+                                  dict(sequence="10",
+                                       grant="permit",
+                                       protocol="ospf",
+                                       source=dict(subnet_address="30.2.0.0/8"),
+                                       destination=dict(any="true"),
+                                       log="true")
+                              ])
+                     ])
+            ], state="replaced"))
+        commands = ['ip access-list test1', 'no 35', 'no 45', '10 permit ospf 30.2.0.0/8 any log']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_eos_acls_replaced_idempotent(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1",
+                              aces=[
+                                  dict(sequence="35",
+                                       grant="deny",
+                                       protocol="tcp",
+                                       source=dict(subnet_address="20.0.0.0/8"),
+                                       destination=dict(any="true"),
+                                       log="true"),
+                                  dict(grant="permit",
+                                       source=dict(any="true"),
+                                       destination=dict(any="true"),
+                                       sequence="45",
+                                       protocol="tcp")
+                              ])
+                     ])
+            ], state="replaced"))
+        self.execute_module(changed=False, commands=[])
+
+    def test_eos_acls_overridden(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1",
+                              aces=[
+                                  dict(sequence="10",
+                                       grant="permit",
+                                       protocol="ospf",
+                                       source=dict(subnet_address="30.2.0.0/8"),
+                                       destination=dict(any="true"),
+                                       log="true")
+                              ])
+                     ])
+            ], state="overridden"))
+        commands = ['ip access-list test1', 'no 35', 'no 45', 'ip access-list test1', '10 permit ospf 30.2.0.0/8 any log']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_eos_acls_overridden_idempotent(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1",
+                              aces=[
+                                  dict(sequence="35",
+                                       grant="deny",
+                                       protocol="tcp",
+                                       source=dict(subnet_address="20.0.0.0/8"),
+                                       destination=dict(any="true"),
+                                       log="true"),
+                                  dict(grant="permit",
+                                       source=dict(any="true"),
+                                       destination=dict(any="true"),
+                                       sequence="45",
+                                       protocol="tcp")
+                              ])
+                     ])
+            ], state="overridden"))
+        self.execute_module(changed=False, commands=[])
+
+    def test_eos_acls_deletedaces(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1",
+                              aces=[
+                                  dict(grant="permit",
+                                       sequence="45",
+                                       source=dict(any="true"),
+                                       destination=dict(any="true"),
+                                       protocol=6)
+                              ])
+                     ])
+            ], state="deleted"))
+        commands = ['ip access-list test1', 'no 45']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_eos_acls_deletedacls(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1")
+                     ])
+            ], state="deleted"))
+        commands = ['no ip access-list test1']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_eos_acls_deletedafis(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4")
+            ], state="deleted"))
+        commands = ['no ip access-list test1']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_eos_acls_gathered(self):
+        set_module_args(
+            dict(config=[],
+                 state="gathered"))
+        result = self.execute_module(changed=False, filename='eos_acls_config.cfg')
+        commands = []
+        for gathered_cmds in result['gathered']:
+            cfg = add_commands(gathered_cmds)
+            commands.append(cfg)
+        commands = list(itertools.chain(*commands))
+        config_commands = ['ip access-list test1', '35 deny tcp 20.0.0.0/8 any log', '45 permit tcp any any']
+        self.assertEqual(sorted(config_commands), sorted(commands), result['gathered'])
+
+    def test_eos_acls_rendered(self):
+        set_module_args(
+            dict(config=[
+                dict(afi="ipv4",
+                     acls=[
+                         dict(name="test1",
+                              aces=[
+                                  dict(grant="permit",
+                                       sequence="45",
+                                       source=dict(any="true"),
+                                       destination=dict(any="true"),
+                                       protocol=6)
+                              ])
+                     ])
+            ], state="rendered"))
+        commands = ['ip access-list test1', '45 permit tcp any any']
+        result = self.execute_module(changed=False)
+        self.assertEqual(sorted(result['rendered']), sorted(commands), result['rendered'])
+
+    def test_eos_acls_parsed(self):
+        set_module_args(
+            dict(running_config="ipv6 access-list test2\n 10 permit icmpv6 host 10.2.33.1 any ttl eq 25",
+                 state="parsed"))
+        commands = ['ipv6 access-list test2', '10 permit icmpv6 host 10.2.33.1 any ttl eq 25']
+        result = self.execute_module(changed=False)
+        parsed_commands = []
+        for cmds in result['parsed']:
+            cfg = add_commands(cmds)
+            parsed_commands.append(cfg)
+        parsed_commands = list(itertools.chain(*parsed_commands))
+        self.assertEqual(sorted(parsed_commands), sorted(commands), result['parsed'])