1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
|
"""Smoke tests for the in-tree PEP 517 backend."""
from __future__ import annotations
from filecmp import dircmp
from os import environ
from pathlib import Path
from shutil import rmtree
from subprocess import check_call, check_output, PIPE
from sys import executable as current_interpreter
from tarfile import TarFile
import typing as t
import pytest
DIST_NAME = 'ansible_core'
DIST_FILENAME_BASE = 'ansible-core'
OUTPUT_DIR = Path(environ['OUTPUT_DIR']).resolve().absolute()
SRC_ROOT_DIR = OUTPUT_DIR.parents[3]
GENERATED_MANPAGES_SUBDIR = SRC_ROOT_DIR / 'docs' / 'man' / 'man1'
LOWEST_SUPPORTED_BUILD_DEPS_FILE = (
Path(__file__).parent / 'minimum-build-constraints.txt'
).resolve().absolute()
MODERNISH_BUILD_DEPS_FILE = (
Path(__file__).parent / 'modernish-build-constraints.txt'
).resolve().absolute()
RELEASE_MODULE = SRC_ROOT_DIR / 'lib' / 'ansible' / 'release.py'
VERSION_LINE_PREFIX = "__version__ = '"
PKG_DIST_VERSION = next(
line[len(VERSION_LINE_PREFIX):-1]
for line in RELEASE_MODULE.read_text().splitlines()
if line.startswith(VERSION_LINE_PREFIX)
)
EXPECTED_SDIST_NAME_BASE = f'{DIST_FILENAME_BASE}-{PKG_DIST_VERSION}'
EXPECTED_SDIST_NAME = f'{EXPECTED_SDIST_NAME_BASE}.tar.gz'
EXPECTED_WHEEL_NAME = f'{DIST_NAME}-{PKG_DIST_VERSION}-py3-none-any.whl'
def wipe_generated_manpages() -> None:
"""Ensure man1 pages aren't present in the source checkout."""
# Cleaning up the gitignored manpages...
if not GENERATED_MANPAGES_SUBDIR.exists():
return
rmtree(GENERATED_MANPAGES_SUBDIR)
# Removed the generated manpages...
def contains_man1_pages(sdist_tarball: Path) -> Path:
"""Check if the man1 pages are present in given tarball."""
with sdist_tarball.open(mode='rb') as tarball_fd:
with TarFile.gzopen(fileobj=tarball_fd, name=None) as tarball:
try:
tarball.getmember(
name=f'{EXPECTED_SDIST_NAME_BASE}/docs/man/man1',
)
except KeyError:
return False
return True
def unpack_sdist(sdist_tarball: Path, target_directory: Path) -> Path:
"""Unarchive given tarball.
:returns: Path of the package source checkout.
"""
with sdist_tarball.open(mode='rb') as tarball_fd:
with TarFile.gzopen(fileobj=tarball_fd, name=None) as tarball:
tarball.extractall(path=target_directory)
return target_directory / EXPECTED_SDIST_NAME_BASE
def assert_dirs_equal(*dir_paths: t.List[Path]) -> None:
dir_comparison = dircmp(*dir_paths)
assert not dir_comparison.left_only
assert not dir_comparison.right_only
assert not dir_comparison.diff_files
assert not dir_comparison.funny_files
def normalize_unpacked_rebuilt_sdist(sdist_path: Path) -> None:
top_pkg_info_path = sdist_path / 'PKG-INFO'
nested_pkg_info_path = (
sdist_path / 'lib' / f'{DIST_NAME}.egg-info' / 'PKG-INFO'
)
entry_points_path = nested_pkg_info_path.parent / 'entry_points.txt'
# setuptools v39 write out two trailing empty lines and an unknown platform
# while the recent don't
top_pkg_info_path.write_text(
top_pkg_info_path.read_text().replace(
'Classifier: Development Status :: 5',
'Platform: UNKNOWN\nClassifier: Development Status :: 5',
) + '\n\n'
)
nested_pkg_info_path.write_text(
nested_pkg_info_path.read_text().replace(
'Classifier: Development Status :: 5',
'Platform: UNKNOWN\nClassifier: Development Status :: 5',
) + '\n\n'
)
# setuptools v39 write out one trailing empty line while the recent don't
entry_points_path.write_text(entry_points_path.read_text() + '\n')
@pytest.fixture
def venv_python_exe(tmp_path: Path) -> t.Iterator[Path]:
venv_path = tmp_path / 'pytest-managed-venv'
mkvenv_cmd = (
current_interpreter, '-m', 'venv', str(venv_path),
)
check_call(mkvenv_cmd, env={}, stderr=PIPE, stdout=PIPE)
yield venv_path / 'bin' / 'python'
rmtree(venv_path)
def build_dists(
python_exe: Path, *cli_args: t.Iterable[str],
env_vars: t.Dict[str, str],
) -> str:
full_cmd = str(python_exe), '-m', 'build', *cli_args
return check_output(full_cmd, env=env_vars, stderr=PIPE)
def pip_install(
python_exe: Path, *cli_args: t.Iterable[str],
env_vars: t.Dict[str, str] = None,
) -> str:
if env_vars is None:
env_vars = {}
full_cmd = str(python_exe), '-m', 'pip', 'install', *cli_args
return check_output(full_cmd, env=env_vars, stderr=PIPE)
def test_dist_rebuilds_with_manpages_premutations(
venv_python_exe: Path, tmp_path: Path,
) -> None:
"""Test a series of sdist rebuilds under different conditions.
This check builds sdists right from the Git checkout with and without
the manpages. It also does this using different versions of the setuptools
PEP 517 build backend being pinned. Finally, it builds a wheel out of one
of the rebuilt sdists.
As intermediate assertions, this test makes simple smoke tests along
the way.
"""
pip_install(venv_python_exe, 'build ~= 0.10.0')
# Test building an sdist without manpages from the Git checkout
tmp_dir_sdist_without_manpages = tmp_path / 'sdist-without-manpages'
wipe_generated_manpages()
build_dists(
venv_python_exe, '--sdist',
f'--outdir={tmp_dir_sdist_without_manpages!s}',
str(SRC_ROOT_DIR),
env_vars={
'PIP_CONSTRAINT': str(MODERNISH_BUILD_DEPS_FILE),
},
)
tmp_path_sdist_without_manpages = (
tmp_dir_sdist_without_manpages / EXPECTED_SDIST_NAME
)
assert tmp_path_sdist_without_manpages.exists()
assert not contains_man1_pages(tmp_path_sdist_without_manpages)
sdist_without_manpages_path = unpack_sdist(
tmp_path_sdist_without_manpages,
tmp_dir_sdist_without_manpages / 'src',
)
# Test building an sdist with manpages from the Git checkout
# and lowest supported build deps
wipe_generated_manpages()
tmp_dir_sdist_with_manpages = tmp_path / 'sdist-with-manpages'
build_dists(
venv_python_exe, '--sdist',
'--config-setting=--build-manpages',
f'--outdir={tmp_dir_sdist_with_manpages!s}',
str(SRC_ROOT_DIR),
env_vars={
'PIP_CONSTRAINT': str(LOWEST_SUPPORTED_BUILD_DEPS_FILE),
},
)
tmp_path_sdist_with_manpages = (
tmp_dir_sdist_with_manpages / EXPECTED_SDIST_NAME
)
assert tmp_path_sdist_with_manpages.exists()
assert contains_man1_pages(tmp_path_sdist_with_manpages)
sdist_with_manpages_path = unpack_sdist(
tmp_path_sdist_with_manpages,
tmp_dir_sdist_with_manpages / 'src',
)
# Test re-building an sdist with manpages from the
# sdist contents that does not include the manpages
tmp_dir_rebuilt_sdist = tmp_path / 'rebuilt-sdist'
build_dists(
venv_python_exe, '--sdist',
'--config-setting=--build-manpages',
f'--outdir={tmp_dir_rebuilt_sdist!s}',
str(sdist_without_manpages_path),
env_vars={
'PIP_CONSTRAINT': str(MODERNISH_BUILD_DEPS_FILE),
},
)
tmp_path_rebuilt_sdist = tmp_dir_rebuilt_sdist / EXPECTED_SDIST_NAME
# Checking that the expected sdist got created
# from the previous unpacked sdist...
assert tmp_path_rebuilt_sdist.exists()
assert contains_man1_pages(tmp_path_rebuilt_sdist)
rebuilt_sdist_path = unpack_sdist(
tmp_path_rebuilt_sdist,
tmp_dir_rebuilt_sdist / 'src',
)
assert rebuilt_sdist_path.exists()
assert rebuilt_sdist_path.is_dir()
normalize_unpacked_rebuilt_sdist(rebuilt_sdist_path)
assert_dirs_equal(rebuilt_sdist_path, sdist_with_manpages_path)
# Test building a wheel from the rebuilt sdist with manpages contents
# and lowest supported build deps
tmp_dir_rebuilt_wheel = tmp_path / 'rebuilt-wheel'
build_dists(
venv_python_exe, '--wheel',
f'--outdir={tmp_dir_rebuilt_wheel!s}',
str(sdist_with_manpages_path),
env_vars={
'PIP_CONSTRAINT': str(LOWEST_SUPPORTED_BUILD_DEPS_FILE),
},
)
tmp_path_rebuilt_wheel = tmp_dir_rebuilt_wheel / EXPECTED_WHEEL_NAME
# Checking that the expected wheel got created...
assert tmp_path_rebuilt_wheel.exists()
def test_pep660_editable_install_smoke(venv_python_exe: Path) -> None:
"""Smoke-test PEP 660 editable install.
This verifies that the in-tree build backend wrapper
does not break any required interfaces.
"""
pip_install(venv_python_exe, '-e', str(SRC_ROOT_DIR))
pip_show_cmd = (
str(venv_python_exe), '-m',
'pip', 'show', DIST_FILENAME_BASE,
)
installed_ansible_meta = check_output(
pip_show_cmd,
env={}, stderr=PIPE, text=True,
).splitlines()
assert f'Name: {DIST_FILENAME_BASE}' in installed_ansible_meta
assert f'Version: {PKG_DIST_VERSION}' in installed_ansible_meta
pip_runtime_version_cmd = (
str(venv_python_exe), '-c',
'from ansible import __version__; print(__version__)',
)
runtime_ansible_version = check_output(
pip_runtime_version_cmd,
env={}, stderr=PIPE, text=True,
).strip()
assert runtime_ansible_version == PKG_DIST_VERSION
|