Fix an assert that occurs when you destroy a rwlock on win32 and later clear

the pool it was allocated from.

Submitted by: Evgueni Brevnov <evgueni.brevnov gmail.com>

* locks/win32/thread_rwlock.c
  (apr_thread_rwlock_destroy): Use apr_pool_cleanup_run to call our cleanup
   function.
  (thread_rwlock_cleanup): Put the destruction of the rwlock here instead
   of in the destructor function.

* test/testlock.c
  (test_thread_rwlocks): Destroy the rwlock explicitly so we can see this
   kind of problem.

* CHANGES: Note change.

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@371172 13f79535-47bb-0310-9956-ffa450edef68

3 files changed, 15 insertions, 8 deletions

diff --git a/CHANGES b/CHANGES
index c9eb14664..5688a3266 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,5 +1,8 @@
 Changes for APR 1.3.0
 
+  *) Fix assertion from double close of a handle with a rwlock on win32.
+     [Evgueni Brevnov <evgueni.brevnov gmail.com>]
+
   *) APR_FIND_APR macro now supports customisable detailed checks on
      each installed apr. [Justin Erenkrantz, Colm MacCarthaigh]
 
diff --git a/locks/win32/thread_rwlock.c b/locks/win32/thread_rwlock.c
index 75d79bcbe..9207d7929 100644
--- a/locks/win32/thread_rwlock.c
+++ b/locks/win32/thread_rwlock.c
@@ -23,7 +23,15 @@
 
 static apr_status_t thread_rwlock_cleanup(void *data)
 {
-    return apr_thread_rwlock_destroy((apr_thread_rwlock_t *) data);
+    apr_thread_rwlock_t *rwlock = data;
+    
+    if (! CloseHandle(rwlock->read_event))
+        return apr_get_os_error();
+
+    if (! CloseHandle(rwlock->write_mutex))
+        return apr_get_os_error();
+    
+    return APR_SUCCESS;
 }
 
 APR_DECLARE(apr_status_t)apr_thread_rwlock_create(apr_thread_rwlock_t **rwlock,
@@ -151,13 +159,7 @@ APR_DECLARE(apr_status_t) apr_thread_rwlock_unlock(apr_thread_rwlock_t *rwlock)
 
 APR_DECLARE(apr_status_t) apr_thread_rwlock_destroy(apr_thread_rwlock_t *rwlock)
 {
-    if (! CloseHandle(rwlock->read_event))
-        return apr_get_os_error();
-
-    if (! CloseHandle(rwlock->write_mutex))
-        return apr_get_os_error();
-    
-    return APR_SUCCESS;
+    return apr_pool_cleanup_run(rwlock->pool, rwlock, thread_rwlock_cleanup);
 }
 
 APR_POOL_IMPLEMENT_ACCESSOR(thread_rwlock)
diff --git a/test/testlock.c b/test/testlock.c
index 8e7943dde..c74164282 100644
--- a/test/testlock.c
+++ b/test/testlock.c
@@ -209,6 +209,8 @@ static void test_thread_rwlock(abts_case *tc, void *data)
     apr_thread_join(&s4, t4);
 
     ABTS_INT_EQUAL(tc, MAX_ITER, x);
+
+    apr_thread_rwlock_destroy(rwlock);
 }
 
 static void test_cond(abts_case *tc, void *data)