summaryrefslogtreecommitdiff
path: root/shmem
diff options
context:
space:
mode:
authorAaron Bannert <aaron@apache.org>2002-01-30 15:33:14 +0000
committerAaron Bannert <aaron@apache.org>2002-01-30 15:33:14 +0000
commitd857322c27780749fc73ccc29289055242c4179b (patch)
treec4ab01d6e61dbf0bf4fe229f9f7fe229be123b06 /shmem
parent52aa939b17914c9224d828d5051fc393afbf3296 (diff)
downloadapr-d857322c27780749fc73ccc29289055242c4179b.tar.gz
Fixed up some comments -- got rid of FIXMEs that have been fixed.
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@62875 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'shmem')
-rw-r--r--shmem/unix/shm.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/shmem/unix/shm.c b/shmem/unix/shm.c
index c493bdc7c..7a2dd9cf3 100644
--- a/shmem/unix/shm.c
+++ b/shmem/unix/shm.c
@@ -152,9 +152,6 @@ APR_DECLARE(apr_status_t) apr_shm_create(apr_shm_t **m,
apr_file_t *file; /* file where metadata is stored */
#endif
- /* FIXME: associate this thing with a pool and set up a destructor
- * to call detach. */
-
/* Check if they want anonymous or name-based shared memory */
if (filename == NULL) {
#if APR_USE_SHMEM_MMAP_ZERO || APR_USE_SHMEM_MMAP_ANON
@@ -474,8 +471,6 @@ APR_DECLARE(apr_status_t) apr_shm_attach(apr_shm_t **m,
new_m->pool = pool;
new_m->filename = apr_pstrdup(pool, filename);
- /* FIXME: open the file, read the length, mmap the segment,
- * close the file, reconstruct the apr_shm_t. */
status = apr_file_open(&file, filename,
APR_READ | APR_WRITE,
APR_OS_DEFAULT, pool);
@@ -512,7 +507,7 @@ APR_DECLARE(apr_status_t) apr_shm_attach(apr_shm_t **m,
return status;
}
- /* metadata isn't usable */
+ /* metadata isn't part of the usable segment */
new_m->usable = new_m->base + sizeof(apr_size_t);
apr_pool_cleanup_register(new_m->pool, new_m, shm_cleanup_attach,