summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Trawick <trawick@apache.org>2005-02-03 12:03:54 +0000
committerJeff Trawick <trawick@apache.org>2005-02-03 12:03:54 +0000
commit7a8893fe328727ff0ea5609d709da267a9ba6ba5 (patch)
tree0cb65172715faaa51f405ad689b4dd3a679a2bb4
parentf611a09378054821d7b1d99c0a0071276e9a7fd1 (diff)
downloadhttpd-proxy-reqbody.tar.gz
spool_reqbody_cl(): mention in commentary that any data weproxy-reqbody
read into memory before reaching our threshold will not be written to disk tweak an existing comment, since "also" does not apply to the situation where we chunk due to an environment variable setting git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@151147 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--modules/proxy/proxy_http.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/modules/proxy/proxy_http.c b/modules/proxy/proxy_http.c
index e3b7f8f2ae..9b7628f12b 100644
--- a/modules/proxy/proxy_http.c
+++ b/modules/proxy/proxy_http.c
@@ -538,7 +538,10 @@ static apr_status_t spool_reqbody_cl(apr_pool_t *p,
apr_brigade_length(input_brigade, 1, &bytes);
if (bytes_spooled + bytes > MAX_MEM_SPOOL) {
- /* can't spool any more in memory; write latest brigade to disk */
+ /* can't spool any more in memory; write latest brigade to disk;
+ * what we read into memory before reaching our threshold will
+ * remain there; we just write this and any subsequent data to disk
+ */
if (tmpfile == NULL) {
const char *temp_dir;
char *template;
@@ -649,8 +652,8 @@ static apr_status_t send_request_body(apr_pool_t *p,
* . if client sent C-L and there are no input resource filters, the
* the body size can't change so we send the same CL and stream the
* body
- * . if client used chunked or proxy-sendchunks is set, we'll also
- * use chunked
+ * . if client used chunked or proxy-sendchunks is set, we'll use
+ * chunked
*
* normal case:
* we have to compute content length by reading the entire request