summaryrefslogtreecommitdiff
path: root/modules/http
diff options
context:
space:
mode:
authorYann Ylavic <ylavic@apache.org>2019-09-16 11:46:27 +0000
committerYann Ylavic <ylavic@apache.org>2019-09-16 11:46:27 +0000
commitc09cdc30b55325be28488a7f13d95730d369f935 (patch)
tree182cc78d54d7b7fdee27c8eb29974eb8e4af40bb /modules/http
parentd14b38da7eafbf8a58451f49c99ce62cbc91b6b1 (diff)
downloadhttpd-c09cdc30b55325be28488a7f13d95730d369f935.tar.gz
ap_http_header_filter: avoid double encoding of output headers in traces.
When output headers are logged (TRACE4) in send_all_header_fields(), we don't need to explicitely ap_escape_logitem() them since ap_log_rerror() takes care of log files escaping already. Otherwise, characters like '"' are unncesseralily encoded, and '\\' is doubly encoded (including for controls). git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1866998 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'modules/http')
-rw-r--r--modules/http/http_filters.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/modules/http/http_filters.c b/modules/http/http_filters.c
index 26440e26de..327d902a3c 100644
--- a/modules/http/http_filters.c
+++ b/modules/http/http_filters.c
@@ -898,8 +898,7 @@ static apr_status_t send_all_header_fields(header_struct *h,
t_elt = (const apr_table_entry_t *)(elts->elts);
do {
ap_log_rerror(APLOG_MARK, APLOG_TRACE4, 0, r, " %s: %s",
- ap_escape_logitem(r->pool, t_elt->key),
- ap_escape_logitem(r->pool, t_elt->val));
+ t_elt->key, t_elt->val);
t_elt++;
} while (t_elt < t_end);
}