| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I ran this on each directory with C files:
clang-format -i *.[ch]
"-i" is the in-place option.
I also adjusted the order of #includes for some files which failed to
build after that:
Clang-format reorders blocks of #include directives alphabetically,
but they can be grouped and separated by blank lines. If there is a
blank line between blocks, like
#include "zork.h"
#include "bar.h"
#include "foo.h"
then it will not put zork.h after the other two. The last two header
files will be sorted alphabetically.
We can adjust the formatting of chunks of code by hand with comments
like these:
/* clang-format off */
this code {
is, formatted, by, hand;
}
/* clang-format on */
See https://clang.llvm.org/docs/ClangFormat.html for the general
manual and https://clang.llvm.org/docs/ClangFormatStyleOptions.html
for the style options and the comments described above.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The comment "TODO this is still memory leak on c->data" from
destroy_deferred_message_item() caught my eye, so I went looking for
what uses it.
defer_message() is the only place that creates BusDataClosure structs,
and gets passed the data field. However, the only caller of
defer_message() is dbus_connection_add_filter(), and *that* call is
done with both NULL user_data and free_data_function. So,
defer_message() will always get data=NULL.
This commit also removes all the "void *user_data" arguments from the
functions called by process_deferred_message(); they just got passed
the closure->data but none of them actually use it.
|
| |
|
|
|
| |
device_remove_datum already implicitly casts its cb to a
AtspiDeviceListenerSimpleCB, which takes a const *event.
|
| | |
|
| |
|
|
| |
Fixes #22.
|
| |
|
|
| |
Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/2
|
| | |
|
| |
|
|
| |
Error logs has different naming convention in atspi/ files.
|
| |
|
|
|
|
| |
This mainly restores the gir entry for AtspiApplication.
https://bugzilla.gnome.org/show_bug.cgi?id=784481
|
| |
|
|
|
|
| |
These are intended as C convenience functions. Gjs doesn't support
having a GDestroyNotify without a user_data and prints out a warning, so
might as well skip for purposes of introspection.
|
| | |
|
| |
|
|
|
| |
There isn't really any point in checking for GLib functions returning NULL
due to lack of memory, since they just abort instead.
|
| | |
|
| | |
|
| |
|
|
|
| |
If a function is non-static and not intended to be public, then precede
its name with an _.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skip atspi_device_listener_new_simple and
atspi-event_listener_new_simple, since Javascript throws an error for
callback functions that don't provide user_data.
Add atspi_event_listener_new.
Change order of user_data and destroy notify parameters in
atspi_device_listener_new to match the order used other places in GNOME.
The old order was triggering an IndexError because of what appears to be
a bug in pygobject. Note that this is an API change and would
ordinarily be a bad idea, but at this point I don't know of anyone using
libatspi directly, so going to commit it.
Some introspection fixes.
|
| |
|
|
|
|
|
| |
If malloc returns NULL, then g_malloc will call g_error and thus abort, so
it is redundant to check the return value of g_new0 and the like, since glib
will already have aborted the program rather than returning a NULL value.
"Cleaning up" the code by removing some of these checks.
|
| |
|
|
|
|
|
| |
Changed device event IPC to use uint32 for hw_code and modifiers, to be
more consistent with the rest of the API.
Kept AT-SPI struct using gushorts to avoid ABI break, and the registry daemon
will continue to accept the old API as well as the new for now.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Events and DeviceEvents are now sent with transfer full to work around
a possible pygi bug.
Various other fixes.
|
| |
|
