diff options
| author | Christophe Fergeau <cfergeau@redhat.com> | 2017-03-21 14:55:13 +0100 |
|---|---|---|
| committer | Peter Simons <simons@cryp.to> | 2017-03-21 16:16:12 +0100 |
| commit | 45f2bf2a9deffb2383051590852c371729561906 (patch) | |
| tree | 69ff50ca4af029872b0718cf325f70597c8e0800 /m4/ax_valgrind_check.m4 | |
| parent | e67ffbceb156a2c33f7c689ff12cef89e8086242 (diff) | |
| download | autoconf-archive-45f2bf2a9deffb2383051590852c371729561906.tar.gz | |
ax_valgrind_check: Don't eat check-valgrind errors
Currently, after running 'make check-valgrind', $? will always be 0 even
if there was an error during the test. This differs from make check
which will return a non-0 exit code when there was a test failure, and
gets in the way of using 'make check-valgrind' during CI.
This commit switches from using make -k on each individual target to
running make -k on all the targets at once. This way, we will run the
tests for all targets even if one fails, while still reporting a non-0
exit code if there was a test failure.
Patch based on a suggestion from Frediano Ziglio <fziglio@redhat.com>
Diffstat (limited to 'm4/ax_valgrind_check.m4')
| -rw-r--r-- | m4/ax_valgrind_check.m4 | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4 index 3761fd5..1c1c0cd 100644 --- a/m4/ax_valgrind_check.m4 +++ b/m4/ax_valgrind_check.m4 @@ -67,7 +67,7 @@ # and this notice are preserved. This file is offered as-is, without any # warranty. -#serial 14 +#serial 15 dnl Configured tools m4_define([valgrind_tool_list], [[memcheck], [helgrind], [drd], [sgcheck]]) @@ -187,9 +187,8 @@ endif # Use recursive makes in order to ignore errors during check check-valgrind: ifeq ($(VALGRIND_ENABLED),yes) - -$(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \ - $(MAKE) $(AM_MAKEFLAGS) -k check-valgrind-$(tool); \ - ) + $(A''M_V_at)$(MAKE) $(AM_MAKEFLAGS) -k \ + $(foreach tool, $(valgrind_enabled_tools), check-valgrind-$(tool)) else @echo "Need to reconfigure with --enable-valgrind" endif |