summaryrefslogtreecommitdiff
path: root/maintainer
diff options
context:
space:
mode:
authorKarl Berry <karl@freefriends.org>2020-03-12 18:01:56 -0700
committerKarl Berry <karl@freefriends.org>2020-03-12 18:01:56 -0700
commit796a2aa51cd2f78a3e122cba62749b9751dafd3a (patch)
treed58efdc5b2e2e05e692fd496b974f86808789c86 /maintainer
parent7665b8e209888c73ee4dc05256f4f09a703a01e5 (diff)
downloadautomake-796a2aa51cd2f78a3e122cba62749b9751dafd3a.tar.gz
maint: do not descend into unreadable test directories.
* maintainer/syntax-checks.mk (sc_tests_makefile_variable_order): find t ! -perm o+r -prune, since some test directories are intentionally unreadable.
Diffstat (limited to 'maintainer')
-rw-r--r--maintainer/syntax-checks.mk9
1 files changed, 6 insertions, 3 deletions
diff --git a/maintainer/syntax-checks.mk b/maintainer/syntax-checks.mk
index 3b32950e4..a28158dc3 100644
--- a/maintainer/syntax-checks.mk
+++ b/maintainer/syntax-checks.mk
@@ -36,9 +36,10 @@ xdefs = \
$(srcdir)/t/ax/test-lib.sh \
$(srcdir)/t/ax/test-defs.in
+# Must prune test dirs since some are intentionally unreadable.
ams := $(shell find $(srcdir) -name '*.dir' -prune -o -name '*.am' -print)
-# Some simple checks, and then ordinary check. These are only really
+# Some simple checks, and then ordinary checks. These are only really
# guaranteed to work on my machine.
syntax_check_rules = \
$(sc_tests_plain_check_rules) \
@@ -105,7 +106,7 @@ sc_sanity_gnu_grep:
$(syntax_check_rules): sc_sanity_gnu_grep
# Check that every subroutine in perl scripts has a corresponding
-# prototype
+# prototype.
sc_perl_protos:
$(AM_V_GEN)$(srcdir)/maintainer/check-perl-protos \
<$(srcdir)/bin/aclocal.in && \
@@ -489,9 +490,11 @@ sc_tests_logs_duplicate_prefixes: sc_ensure_testsuite_has_run
fi
# Ensure variables are listed before rules in Makefile.in files we generate.
+# (Do not descend into test dirs that are unreadable.)
sc_tests_makefile_variable_order: sc_ensure_testsuite_has_run
@st=0; \
- for file in `find t -name Makefile.in -print`; do \
+ for file in `find t ! -perm -o+r -prune -o -name Makefile.in -print`; \
+ do \
latevars=`sed -n \
-e :x -e 's/#.*//' \
-e '/\\\\$$/{' -e N -e 'b x' -e '}' \