| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
fixed all warning messages when enabling -Wall option (v2)
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixed the below warning messages.
- warning: comparison between signed and unsigned integer expressions
- warning: no return statement in function returning non-void
- warning: statement has no effect
- warning: unused variable
- warning: when initialized here [-Wreorder]
- warning: control reaches end of non-void function [-Wreturn-type]
- warning: ‘VehicleProperty::ButtonEvent’ is deprecated: Deprecated in
0.14. Use ButtonEventW3C [-Wdeprecated-declarations]
- warning: ignoring return value of 'int dup(int)', declared with
attribute warn_unused_result [-Wunused-result]
- warning: suggest parentheses around '&&' within '||' [-Wparentheses]
- warning: 'connection' may be used uninitialized in this function
[-Wmaybe-uninitialized]
- warning: suggest parentheses around assignment used as truth value
- warning: dereferencing type-punned pointer will break strict-aliasing rules
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some generated functions by AmbSignalMapper do not return the result
even it is not a void function. Because of this reason, below error
occurs when build it. This patch fixes this bug.
---------------------------------------------------------------------
warning: control reaches end of non-void function [-Wreturn-type]
---------------------------------------------------------------------
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|\
| |
| | |
AmbSignalMapper: bugfix about configuration
|
|/
|
|
|
|
|
|
|
| |
If 'announcementCount' variable is lower than 1, then
'announcementIntervalTimer' variable is updated to 1. That is definitely
a bug so this patch fixes that error by updating 'announcementCount'
instead of 'announcementIntervalTimer'.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|\
| |
| | |
Fix #78, #79, #82 issues (v2)
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Even though generated codes by AmbSignalMapper are built as 64bits environment,
shared library is installed in fixed directory (i.e. lib/automotive-message-broker)
since there is an error in CMakeLists.txt. This patch fixes this bug and
use pre-defined GNU standard macro for more adaptable.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Generated pkgconfig files(i.e. *.pc) have the wrong path as below.
Because of this reason, include files are not found when building AMB
plugin module.
---------------------------------------------
$ cat /usr/local/lib/pkgconfig/amb-plugins-common.pc
prefix=/usr/local
exec_prefix=${prefix}
libdir=lib
includedir=include/amb
---------------------------------------------
This patch fixes this problem by adding prefix macro in front of libdir
and includedir.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running 'ambctl listen' command, below error occurs.
-----------------------------------------------------------
$ ambctl listen VehicleSpeed
File "/usr/local/bin/ambctl", line 567, in <module>
processCommand(args.command, args.commandArgs, False)
File "/usr/local/bin/ambctl", line 218, in processCommand
traceback.print_stack()
-----------------------------------------------------------
This is mainly because gobject is replaced with gi.repository module so
it should be GObject not gobject.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|\
| |
| | |
Fix compile time error when building generated code by json2amb
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generated c++ codes by json2amb use 'auto' keyword. However, Generated
CMakeLists.txt has '-std=gnu++0x' option. Because of this reason, below
errors occur.
---------------------------------------
error: use of ‘auto’ in lambda parameter declaration only available with
-std=c++14 or -std=gnu++14
---------------------------------------
This patch fixes the bug by using '-std=c++14' instead of
'-std=gnu++0x'
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|\
| |
| | |
Fix Undefined subroutine error in json2amb script
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to generate plugin from JSON file, json2amb script is used.
However, below error occurs when executing json2amb script.
------------------------------------------------------------------------
$ json2amb -d SamsungCAN.json
Undefined subroutine &main::readFileContent called at
/usr/local/bin/json2amb line 111.
------------------------------------------------------------------------
This is mainly because readFileContent() subroutine is located in
Intel::IviPoc::AmbCommon but it is not loaded in json2amb script. This
patch fixes the error.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|\
| |
| | |
Fix gpsnmea plugin snippit and fidl
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Add unpackaged files into rpm package
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some files are installed but not packaged into any rpm packages. Because
of this reason, below error occurs when building rpm packages.
--------------------------------------------------
[ 158s] error: Installed (but unpackaged) file(s) found:
[ 158s] /etc/init.d/ambd
[ 158s] /usr/lib/debug/usr/lib/libamb-json-protocol.so.debug
[ 158s] /usr/lib/libamb-json-protocol.so
[ 158s]
[ 158s]
[ 158s] RPM build errors:
[ 158s] Installed (but unpackaged) file(s) found:
[ 158s] /etc/init.d/ambd
[ 158s] /usr/lib/debug/usr/lib/libamb-json-protocol.so.debug
[ 158s] /usr/lib/libamb-json-protocol.so
--------------------------------------------------
This patch fixes the error above by adding these files into proper
packages.
Change-Id: I9a7de2bc2b90dfd0b955f459c2e961fe93476470
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
|
|\ \
| | |
| | | |
cmake: assorted install path fixes
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
- Avoid double prefix in PLUGIN_INSTALL_PATH
- Avoid leading "//" in PLUGIN_SEGMENT_INSTALL_PATH - cmake will think
it's a network directory
- Use installation directory variable in amb-qt installation
Signed-off-by: Frederico Cadete <frederico.cadete@awtce.be>
|
|\ \
| |/
| | |
timestamp: fix for bcm_timeval on older kernels
|
| | |
|
|/ |
|
|\
| |
| | |
fix can error. fix cmake plugin_install_dir
|
| |
| |
| |
| |
| | |
can: add bcm_timestamp conversion. timeval to bcm_timeval conversion doesn't work with new gcc
cmake: Fix install path for plugins. Was not being populated properly
|
|\ \
| | |
| | | |
docs: Correct errors and inconsistencies in climate control section
|
|/ /
| |
| |
| |
| |
| |
| | |
Resolve an error in the climate control documentation related to the fan
speed level and resolve a few trivial inconsistencies nearby.
Signed-off-by: Matthew Vick <mvick@jaguarlandrover.com>
|
|\ \
| |/
| | |
cmake: explicitly set std to c++14
|
| | |
|
| | |
|
|/
|
|
| |
Signed-off-by: Kevron Rees <tripzero.kev@gmail.com>
|
|\
| |
| |
| |
| | |
Version bump and Value Quality
Merging as-is for now
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
updateFrequency a separate property
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Bugfix: parsing of plugins.d failed with some file-systems
|
|/ |
|
|\
| |
| | |
Chrony for master - This has already been reviewed on 0.14. Merging
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\
| |
| | |
Fixes and improvements in CAN support
|
| | |
|