diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2022-09-14 15:52:49 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2022-09-14 15:52:49 +0200 |
| commit | a80f38d3c59c934897106b79051ce71cf122ad8a (patch) | |
| tree | 733b7f0b3d5566174d18b7aa3308c3b6f7c3f63d /commands | |
| parent | 36b901f5a62ff334fb7768aca644fe11f1efbc10 (diff) | |
| parent | 83ff1fc386f3585baa5ec6055909588bef4685d5 (diff) | |
| download | barebox-a80f38d3c59c934897106b79051ce71cf122ad8a.tar.gz | |
Merge branch 'for-next/clang-analyze'
Diffstat (limited to 'commands')
| -rw-r--r-- | commands/trigger.c | 5 | ||||
| -rw-r--r-- | commands/tutorial.c | 7 |
2 files changed, 3 insertions, 9 deletions
diff --git a/commands/trigger.c b/commands/trigger.c index c1402b66f0..d2802080b9 100644 --- a/commands/trigger.c +++ b/commands/trigger.c @@ -16,7 +16,7 @@ static int do_trigger(int argc, char *argv[]) { - struct led *led = NULL; + struct led *led; int opt, ret = 0; int cmd = LED_COMMAND_SHOW_INFO; enum led_trigger trigger; @@ -35,9 +35,6 @@ static int do_trigger(int argc, char *argv[]) } } - if (optind < argc) - led = led_by_name_or_number(argv[optind]); - switch (cmd) { case LED_COMMAND_SHOW_INFO: led_triggers_show_info(); diff --git a/commands/tutorial.c b/commands/tutorial.c index 4441777643..afe5b66f0b 100644 --- a/commands/tutorial.c +++ b/commands/tutorial.c @@ -84,7 +84,6 @@ out: static int do_tutorial_next(int argc, char *argv[]) { int opt, i; - char *step = NULL; char *oldcwd; ssize_t ret = 0; bool is_prev = *argv[0] == 'p'; @@ -121,14 +120,12 @@ static int do_tutorial_next(int argc, char *argv[]) next_step = next_step > 0 ? next_step - 1 : 0; if (optind == argc) { - step = steps.gl_pathv[next_step]; - ret = print_tutorial_step(step); + ret = print_tutorial_step(steps.gl_pathv[next_step]); if (ret == 0 && !is_prev) next_step = (next_step + 1) % steps.gl_pathc; } else { for (i = optind; i < argc; i++) { - step = strdup(argv[i]); - ret = print_tutorial_step(step); + ret = print_tutorial_step(argv[i]); if (ret) break; } |