summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Maidanski <ivmai@mail.ru>2022-10-31 22:08:56 +0300
committerIvan Maidanski <ivmai@mail.ru>2022-11-01 00:53:16 +0300
commitdf2b087294138ae63e86f0779daf4508b0073bda (patch)
treec2cf00e6a9ef513047adf751e99efcd6be7622f0
parent956314c29adbec7d5c63282b7e399e1a7f3df202 (diff)
downloadbdwgc-df2b087294138ae63e86f0779daf4508b0073bda.tar.gz
Eliminate 'cast signed to bigger unsigned' CSA warning in WARN calls
* pthread_support.c [HAVE_PTHREAD_SETNAME_NP_WITH_TID_AND_ARG] (set_marker_thread_name): Cast WARN argument to signed_word. * pthread_support.c [PARALLEL_MARK] (GC_start_mark_threads_inner): Likewise. * pthread_support.c [GC_LINUX_THREADS && !HOST_ANDROID && !NACL] (GC_get_nprocs): Likewise. * pthread_support.c (GC_thr_init): Likewise. * win32_threads.c [PARALLEL_MARK] (GC_start_mark_threads_inner): Likewise.
-rw-r--r--pthread_support.c16
-rw-r--r--win32_threads.c13
2 files changed, 18 insertions, 11 deletions
diff --git a/pthread_support.c b/pthread_support.c
index 7c501e4d..a009a1db 100644
--- a/pthread_support.c
+++ b/pthread_support.c
@@ -341,7 +341,8 @@ STATIC int GC_nprocs = 1;
int err = pthread_setname_np(pthread_self(), "GC-marker-%zu",
(void*)(size_t)id);
if (EXPECT(err != 0, FALSE))
- WARN("pthread_setname_np failed, errno= %" WARN_PRIdPTR "\n", err);
+ WARN("pthread_setname_np failed, errno= %" WARN_PRIdPTR "\n",
+ (signed_word)err);
}
#elif defined(HAVE_PTHREAD_SETNAME_NP_WITH_TID) \
|| defined(HAVE_PTHREAD_SETNAME_NP_WITHOUT_TID)
@@ -506,7 +507,7 @@ GC_INNER void GC_start_mark_threads_inner(void)
if (REAL_FUNC(pthread_sigmask)(SIG_BLOCK, &set, &oldset) < 0) {
WARN("pthread_sigmask set failed, no markers started,"
- " errno= %" WARN_PRIdPTR "\n", errno);
+ " errno= %" WARN_PRIdPTR "\n", (signed_word)errno);
GC_markers_m1 = 0;
(void)pthread_attr_destroy(&attr);
return;
@@ -521,7 +522,8 @@ GC_INNER void GC_start_mark_threads_inner(void)
if (REAL_FUNC(pthread_create)(&new_thread, &attr, GC_mark_thread,
(void *)(word)i) != 0) {
- WARN("Marker thread %" WARN_PRIdPTR " creation failed\n", i);
+ WARN("Marker thread %" WARN_PRIdPTR " creation failed\n",
+ (signed_word)i);
/* Don't try to create other marker threads. */
GC_markers_m1 = i;
break;
@@ -532,7 +534,7 @@ GC_INNER void GC_start_mark_threads_inner(void)
/* Restore previous signal mask. */
if (REAL_FUNC(pthread_sigmask)(SIG_SETMASK, &oldset, NULL) < 0) {
WARN("pthread_sigmask restore failed, errno= %" WARN_PRIdPTR "\n",
- errno);
+ (signed_word)errno);
}
# endif
@@ -926,7 +928,8 @@ GC_API void GC_CALL GC_register_altstack(void *normstack,
len = STAT_READ(f, stat_buf, sizeof(stat_buf)-1);
/* Unlikely that we need to retry because of an incomplete read here. */
if (len < 0) {
- WARN("Failed to read /proc/stat, errno= %" WARN_PRIdPTR "\n", errno);
+ WARN("Failed to read /proc/stat, errno= %" WARN_PRIdPTR "\n",
+ (signed_word)errno);
close(f);
return 1;
}
@@ -1419,7 +1422,8 @@ GC_INNER void GC_thr_init(void)
GC_nprocs = GC_get_nprocs();
}
if (GC_nprocs <= 0) {
- WARN("GC_get_nprocs() returned %" WARN_PRIdPTR "\n", GC_nprocs);
+ WARN("GC_get_nprocs() returned %" WARN_PRIdPTR "\n",
+ (signed_word)GC_nprocs);
GC_nprocs = 2; /* assume dual-core */
# ifdef PARALLEL_MARK
available_markers_m1 = 0; /* but use only one marker */
diff --git a/win32_threads.c b/win32_threads.c
index 70bff927..69209a6b 100644
--- a/win32_threads.c
+++ b/win32_threads.c
@@ -2003,7 +2003,7 @@ GC_INNER void GC_get_next_stack(char *start, char *limit,
ABORT("sigfillset failed");
if (EXPECT(pthread_sigmask(SIG_BLOCK, &set, &oldset) < 0, FALSE)) {
WARN("pthread_sigmask set failed, no markers started,"
- " errno= %" WARN_PRIdPTR "\n", errno);
+ " errno= %" WARN_PRIdPTR "\n", (signed_word)errno);
GC_markers_m1 = 0;
(void)pthread_attr_destroy(&attr);
return;
@@ -2017,7 +2017,8 @@ GC_INNER void GC_get_next_stack(char *start, char *limit,
marker_last_stack_min[i] = ADDR_LIMIT;
if (EXPECT(0 != pthread_create(&new_thread, &attr, GC_mark_thread,
(void *)(word)i), FALSE)) {
- WARN("Marker thread %" WARN_PRIdPTR " creation failed\n", i);
+ WARN("Marker thread %" WARN_PRIdPTR " creation failed\n",
+ (signed_word)i);
/* Don't try to create other marker threads. */
GC_markers_m1 = i;
break;
@@ -2028,7 +2029,7 @@ GC_INNER void GC_get_next_stack(char *start, char *limit,
/* Restore previous signal mask. */
if (EXPECT(pthread_sigmask(SIG_SETMASK, &oldset, NULL) < 0, FALSE)) {
WARN("pthread_sigmask restore failed, errno= %" WARN_PRIdPTR "\n",
- errno);
+ (signed_word)errno);
}
# endif
@@ -2179,7 +2180,8 @@ GC_INNER void GC_get_next_stack(char *start, char *limit,
GC_mark_thread, (LPVOID)(word)i,
0 /* fdwCreate */, &thread_id);
if (EXPECT(NULL == handle, FALSE)) {
- WARN("Marker thread %" WARN_PRIdPTR " creation failed\n", i);
+ WARN("Marker thread %" WARN_PRIdPTR " creation failed\n",
+ (signed_word)i);
/* The most probable failure reason is "not enough memory". */
/* Don't try to create other marker threads. */
break;
@@ -2195,7 +2197,8 @@ GC_INNER void GC_get_next_stack(char *start, char *limit,
MARK_THREAD_STACK_SIZE, GC_mark_thread,
(void *)(word)i, 0 /* flags */, &thread_id);
if (EXPECT(!handle || handle == (GC_uintptr_t)-1L, FALSE)) {
- WARN("Marker thread %" WARN_PRIdPTR " creation failed\n", i);
+ WARN("Marker thread %" WARN_PRIdPTR " creation failed\n",
+ (signed_word)i);
/* Don't try to create other marker threads. */
break;
} else {/* We may detach the thread (if handle is of HANDLE type) */