summaryrefslogtreecommitdiff
path: root/cord
diff options
context:
space:
mode:
authorIvan Maidanski <ivmai@mail.ru>2016-12-10 01:54:05 +0300
committerIvan Maidanski <ivmai@mail.ru>2016-12-10 01:55:20 +0300
commitfbdd97254de38951a859e9a96cf08f77435bb05a (patch)
tree369ee2f1541612da4cdaf974e881bf418b164ad3 /cord
parentd87636e22df9d5985d0a38219ecc0b47978173e0 (diff)
downloadbdwgc-fbdd97254de38951a859e9a96cf08f77435bb05a.tar.gz
Eliminate 'use of vulnerable sprintf' code defect in de_win test (cord)
* cord/tests/de_win.c (WinMain): Do not call sprintf() on RegisterClass and CreateWindow failure; invoke de_error() with the immediate error message strings (without the error code).
Diffstat (limited to 'cord')
-rw-r--r--cord/tests/de_win.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/cord/tests/de_win.c b/cord/tests/de_win.c
index b36d864c..0af00df4 100644
--- a/cord/tests/de_win.c
+++ b/cord/tests/de_win.c
@@ -62,11 +62,7 @@ int APIENTRY WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance,
wndclass.lpszClassName = szAppName;
if (RegisterClass (&wndclass) == 0) {
- char buf[50];
-
- sprintf(buf, "RegisterClass: error code: 0x%X",
- (unsigned)GetLastError());
- de_error(buf);
+ de_error("RegisterClass error");
return(0);
}
}
@@ -99,11 +95,7 @@ int APIENTRY WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance,
NULL, /* Window class menu */
hInstance, NULL);
if (hwnd == NULL) {
- char buf[50];
-
- sprintf(buf, "CreateWindow: error code: 0x%X",
- (unsigned)GetLastError());
- de_error(buf);
+ de_error("CreateWindow error");
return(0);
}