Workaround 'duplicate expression for condition and assignment' cppcheck FP

The entitled cppcheck warnings are false positives.

* alloc.c (GC_should_collect): Move reassignment of the global variable
which is checked in the conditional expression to the end of the
conditional block statement.
* finalize.c (GC_notify_or_invoke_finalizers): Likewise.
* mark.c [WRAP_MARK_SOME] (GC_mark_some): Likewise.

1 files changed, 1 insertions, 1 deletions

diff --git a/finalize.c b/finalize.c
index d01c2aa8..5c23b4c4 100644
--- a/finalize.c
+++ b/finalize.c
@@ -1368,8 +1368,8 @@ GC_INNER void GC_notify_or_invoke_finalizers(void)
 
     /* These variables require synchronization to avoid data races.     */
     if (last_finalizer_notification != GC_gc_no) {
-        last_finalizer_notification = GC_gc_no;
         notifier_fn = GC_finalizer_notifier;
+        last_finalizer_notification = GC_gc_no;
     }
     UNLOCK();
     if (notifier_fn != 0)