diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-12-03 16:31:09 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-12-14 08:47:48 -0500 |
| commit | 9bc8e54b1f1c281c7a4ecf49a4e9300e334beb0a (patch) | |
| tree | a14d07055ccb22a4858f58147c5492ca55460425 /bfd/elf32-lm32.c | |
| parent | 78d4da9ae0d3447f28274a00b278f58ca7d8d1b2 (diff) | |
| download | binutils-gdb-9bc8e54b1f1c281c7a4ecf49a4e9300e334beb0a.tar.gz | |
bfd: fix -Wunused errors with clang 13+
Clang 13 and 14 produce some -Wunused-but-set-{variable,parameter} for
situations where gcc doesn't. In particular, when a variable is set and
then used in a way to update its own value. For example, if `i` is only
used in this way:
int i = 2;
i++;
i = i + 1;
gcc won't warn, but clang will.
Fix all such errors found in an --enable-targets=all build. It would be
important for somebody who knows what they're doing to just make sure
that these variables can indeed be deleted, and that there a no cases
where it's a bug, and the variable should actually be used.
The first instance of this error fix by this patch is:
CC elf32-score.lo
/home/simark/src/binutils-gdb/bfd/elf32-score.c:450:11: error: variable 'relocation' set but not used [-Werror,-Wunused-but-set-variable]
bfd_vma relocation;
^
Change-Id: I2f233ce20352645cf388aff3dfa08a651d21a6b6
Diffstat (limited to 'bfd/elf32-lm32.c')
| -rw-r--r-- | bfd/elf32-lm32.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/bfd/elf32-lm32.c b/bfd/elf32-lm32.c index be8d41632c1..779b6817dfd 100644 --- a/bfd/elf32-lm32.c +++ b/bfd/elf32-lm32.c @@ -1120,7 +1120,7 @@ lm32_elf_check_relocs (bfd *abfd, const Elf_Internal_Rela *relocs) { Elf_Internal_Shdr *symtab_hdr; - struct elf_link_hash_entry **sym_hashes, **sym_hashes_end; + struct elf_link_hash_entry **sym_hashes; const Elf_Internal_Rela *rel; const Elf_Internal_Rela *rel_end; struct elf_lm32_link_hash_table *htab; @@ -1131,9 +1131,6 @@ lm32_elf_check_relocs (bfd *abfd, symtab_hdr = &elf_tdata (abfd)->symtab_hdr; sym_hashes = elf_sym_hashes (abfd); - sym_hashes_end = sym_hashes + symtab_hdr->sh_size/sizeof (Elf32_External_Sym); - if (!elf_bad_symtab (abfd)) - sym_hashes_end -= symtab_hdr->sh_info; htab = lm32_elf_hash_table (info); if (htab == NULL) |