diff options
| author | Alan Modra <amodra@gmail.com> | 2018-12-18 09:20:06 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2018-12-18 10:47:02 +1030 |
| commit | 7af5d5c4dda26ac36ee2ff42af8f39a10382cc41 (patch) | |
| tree | ea96ed2204aee3212b07516b827b30a0b779192f /bfd/elf32-sh.c | |
| parent | c5ebe0ff706521b4a5fb66a5e764031825276ad5 (diff) | |
| download | binutils-gdb-7af5d5c4dda26ac36ee2ff42af8f39a10382cc41.tar.gz | |
PR23980, assertion fail
All of the backend relocate_section functions that interpret reloc
numbers assuming the input file is of the expected type (ie. same as
output or very similar) really ought to be checking input file type.
Not many do, and those that do currently just assert. This patch
replaces the assertion with a more graceful exit.
PR 23980
* elf32-i386.c (elf_i386_relocate_section): Exit with wrong format
error rather than asserting input file is as expected.
* elf32-s390.c (elf_s390_relocate_section): Likewise.
* elf32-sh.c (sh_elf_relocate_section): Likewise.
* elf32-xtensa.c (elf_xtensa_relocate_section): Likewise.
* elf64-ppc.c (ppc64_elf_relocate_section): Likewise.
* elf64-s390.c (elf_s390_relocate_section): Likewise.
* elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.
* elf32-ppc.c (ppc_elf_relocate_section): Exit with wrong format
error if input file is not ppc32 ELF.
Diffstat (limited to 'bfd/elf32-sh.c')
| -rw-r--r-- | bfd/elf32-sh.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c index 1b391090d8e..bcfcec70d0a 100644 --- a/bfd/elf32-sh.c +++ b/bfd/elf32-sh.c @@ -3510,7 +3510,11 @@ sh_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info, unsigned isec_segment, got_segment, plt_segment, check_segment[2]; bfd_boolean fdpic_p = FALSE; - BFD_ASSERT (is_sh_elf (input_bfd)); + if (!is_sh_elf (input_bfd)) + { + bfd_set_error (bfd_error_wrong_format); + return FALSE; + } htab = sh_elf_hash_table (info); if (htab != NULL) |