diff options
| author | Jan Beulich <jbeulich@suse.com> | 2023-04-04 08:50:18 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2023-04-04 08:50:18 +0200 |
| commit | 02d44d76584e4d483fe0fc677c12066ec23d67f4 (patch) | |
| tree | 17973e7043745217bd770cf83b9795097a166858 /bfd | |
| parent | 19cacf672930cee20feaf1f3468e3d5ac3099ffd (diff) | |
| download | binutils-gdb-02d44d76584e4d483fe0fc677c12066ec23d67f4.tar.gz | |
bfd+ld: when / whether to generate .c files
Having been irritated by seeing bfd/elf{32,64}-aarch64.c to be re-
generated in x86-only builds, I came across 769a27ade588 ("Re: bfd
BLD-POTFILES.in dependencies"). I think this went slightly too far, as
outside of maintainer mode dependencies will cause the subset of files
to be (re-)generated which are actually needed for the build.
Generating them all is only needed when wanting to update certain files
under bfd/po/, i.e. in maintainer mode.
In the course of looking around in an attempt to try to understand how
things are meant to work, I further noticed that ld has got things
slightly wrong too: BLD-POTFILES.in depending on $(BLD_POTFILES) isn't
quite right (the output doesn't change when any of the enumerated files
changes; it's the mere presence which matters); like in bfd it looks
like we would better extend BUILT_SOURCES accordingly.
Furthermore it became apparent that ld fails to enumerate the .c files
generated from the .l and .y ones. While in their absence it was benign
whether translatable strings in the source files were actually marked as
such, this now becomes relevant. Mark respective strings at the same
time, but skipping ones which look to be of interest for debugging
purposes only (e.g. such used by printf() enclosed in #ifdef TRACE).
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/Makefile.am | 2 | ||||
| -rw-r--r-- | bfd/Makefile.in | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/bfd/Makefile.am b/bfd/Makefile.am index 931b2cbdcd6..099229347b5 100644 --- a/bfd/Makefile.am +++ b/bfd/Makefile.am @@ -721,7 +721,7 @@ BUILD_HFILES = \ bfdver.h elf32-target.h elf64-target.h targmatch.h # Ensure they are built early: -BUILT_SOURCES = $(BUILD_HFILES) $(BUILD_CFILES) +BUILT_SOURCES = $(BUILD_HFILES) @MAINT@ $(BUILD_CFILES) HFILES = $(SOURCE_HFILES) $(BUILD_HFILES) diff --git a/bfd/Makefile.in b/bfd/Makefile.in index 82aa96f30e5..5be3d1b6e9f 100644 --- a/bfd/Makefile.in +++ b/bfd/Makefile.in @@ -1174,7 +1174,7 @@ BUILD_HFILES = \ # Ensure they are built early: -BUILT_SOURCES = $(BUILD_HFILES) $(BUILD_CFILES) +BUILT_SOURCES = $(BUILD_HFILES) @MAINT@ $(BUILD_CFILES) HFILES = $(SOURCE_HFILES) $(BUILD_HFILES) BFD_H_DEPS = $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h $(INCDIR)/diagnostics.h LOCAL_H_DEPS = libbfd.h sysdep.h config.h |