diff options
| author | Nick Clifton <nickc@redhat.com> | 2022-12-21 11:51:23 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2022-12-21 11:51:23 +0000 |
| commit | 75393a2d54bcc40053e5262a3de9d70c5ebfbbfd (patch) | |
| tree | 28993ec7922c46884dbd1602d1bef9aaa8279642 /binutils | |
| parent | a7a32d588f29466221f5b4d421d0fc0a652dae48 (diff) | |
| download | binutils-gdb-75393a2d54bcc40053e5262a3de9d70c5ebfbbfd.tar.gz | |
Fix an attempt to allocate an unreasonably large amount of memory when parsing a corrupt ELF file.
PR 29924
* objdump.c (load_specific_debug_section): Check for excessively
large sections.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/ChangeLog | 6 | ||||
| -rw-r--r-- | binutils/objdump.c | 4 |
2 files changed, 9 insertions, 1 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index e7f918d3f65..020e09f3700 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2022-12-21 Nick Clifton <nickc@redhat.com> + + PR 29924 + * objdump.c (load_specific_debug_section): Check for excessively + large sections. + 2022-12-19 Tom Tromey <tromey@adacore.com> * dwarf-mode.el (dwarf-do-refresh): Avoid compiler warning. diff --git a/binutils/objdump.c b/binutils/objdump.c index d51abbe3858..2eb02de0e76 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -4225,7 +4225,9 @@ load_specific_debug_section (enum dwarf_section_display_enum debug, section->size = bfd_section_size (sec); /* PR 24360: On 32-bit hosts sizeof (size_t) < sizeof (bfd_size_type). */ alloced = amt = section->size + 1; - if (alloced != amt || alloced == 0) + if (alloced != amt + || alloced == 0 + || (bfd_get_size (abfd) != 0 && alloced >= bfd_get_size (abfd))) { section->start = NULL; free_debug_section (debug); |