diff options
| author | Tom Tromey <tromey@adacore.com> | 2023-04-19 09:40:20 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2023-05-12 12:30:28 -0600 |
| commit | 9c0fb73485cb2c90bb10cb4d3cf1d27e36f9ff01 (patch) | |
| tree | 88f1ca4555a484b28c4fcbe822ac8c925835fd8b /gdb/compile/compile-cplus-types.c | |
| parent | 14e8fded85efa824e6652ed876229e5c24758b72 (diff) | |
| download | binutils-gdb-9c0fb73485cb2c90bb10cb4d3cf1d27e36f9ff01.tar.gz | |
Add dynamic_prop::is_constant
I noticed many spots checking whether a dynamic property's kind is
PROP_CONST. Some spots, I think, are doing a slightly incorrect check
-- checking for != PROP_UNDEFINED where == PROP_CONST is actually
required, the key thing being that const_val may only be called for
PROP_CONST properties.
This patch adds dynamic::is_constant and then updates these checks to
use it.
Regression tested on x86-64 Fedora 36.
Diffstat (limited to 'gdb/compile/compile-cplus-types.c')
| -rw-r--r-- | gdb/compile/compile-cplus-types.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c index 2f87ad865fa..d8e305f237a 100644 --- a/gdb/compile/compile-cplus-types.c +++ b/gdb/compile/compile-cplus-types.c @@ -455,7 +455,7 @@ compile_cplus_convert_array (compile_cplus_instance *instance, struct type *range = type->index_type (); gcc_type element_type = instance->convert_type (type->target_type ()); - if (range->bounds ()->low.kind () != PROP_CONST) + if (!range->bounds ()->low.is_constant ()) { const char *s = _("array type with non-constant" " lower bound is not supported"); |