diff options
| author | Tom Tromey <tom@tromey.com> | 2022-05-21 09:50:13 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-05-31 14:46:11 -0600 |
| commit | e2904e1ff0b0158cf6d8d335ca3f80ff7dc9eb6c (patch) | |
| tree | a964217ffa81df1df4ec9236cb0a3696bf2ff3e4 /gdb/progspace.c | |
| parent | ebad7c66133526eb9ea9b21dad2df49a65200df0 (diff) | |
| download | binutils-gdb-e2904e1ff0b0158cf6d8d335ca3f80ff7dc9eb6c.tar.gz | |
Use unique_ptr for objfiles
A while back, I changed objfiles to be held via a shared_ptr. The
idea at the time was that this was a step toward writing to the index
cache in the background, and this would let gdb keep a reference alive
to do so. However, since then we've rewritten the DWARF reader, and
the new index can do this without requiring a shared pointer -- in
fact there are patches pending to implement this.
This patch switches objfile management to unique_ptr, which makes more
sense now.
Regression tested on x86-64 Fedora 34.
Diffstat (limited to 'gdb/progspace.c')
| -rw-r--r-- | gdb/progspace.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/progspace.c b/gdb/progspace.c index 1ee4fe3f940..8735343fabc 100644 --- a/gdb/progspace.c +++ b/gdb/progspace.c @@ -174,7 +174,7 @@ program_space::free_all_objfiles () /* See progspace.h. */ void -program_space::add_objfile (std::shared_ptr<objfile> &&objfile, +program_space::add_objfile (std::unique_ptr<objfile> &&objfile, struct objfile *before) { if (before == nullptr) @@ -182,7 +182,7 @@ program_space::add_objfile (std::shared_ptr<objfile> &&objfile, else { auto iter = std::find_if (objfiles_list.begin (), objfiles_list.end (), - [=] (const std::shared_ptr<::objfile> &objf) + [=] (const std::unique_ptr<::objfile> &objf) { return objf.get () == before; }); @@ -203,7 +203,7 @@ program_space::remove_objfile (struct objfile *objfile) reinit_frame_cache (); auto iter = std::find_if (objfiles_list.begin (), objfiles_list.end (), - [=] (const std::shared_ptr<::objfile> &objf) + [=] (const std::unique_ptr<::objfile> &objf) { return objf.get () == objfile; }); |