diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2022-07-25 12:07:11 +0100 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2022-07-26 12:04:07 +0100 |
| commit | ab25d9bbe4a04aefb47d2514b4b02e6035ff769e (patch) | |
| tree | 4ac73d86e7ca5fe334eab657a3b716b44730270f /gdb/xtensa-tdep.h | |
| parent | 27121f6740fa2051609b2d781d77c4cd23aa590b (diff) | |
| download | binutils-gdb-ab25d9bbe4a04aefb47d2514b4b02e6035ff769e.tar.gz | |
gdb: rename gdbarch_tdep struct to fix g++ 4.8 build
After the commit:
commit 08106042d9f5fdff60c129bf33190639f1a98b2a
Date: Thu May 19 13:20:17 2022 +0100
gdb: move the type cast into gdbarch_tdep
GDB would no longer build using g++ 4.8. The issue appears to be some
confusion caused by GDB having 'struct gdbarch_tdep', but also a
templated function called 'gdbarch_tdep'. Prior to the above commit
the gdbarch_tdep function was not templated, and this compiled just
fine. Note that the above commit compiles just fine with later
versions of g++, so this issue was clearly fixed at some point, though
I've not tried to track down exactly when.
In this commit I propose to fix the g++ 4.8 build problem by renaming
'struct gdbarch_tdep' to 'struct gdbarch_tdep_base'. This rename
better represents that the struct is only ever used as a base class,
and removes the overloading of the name, which allows GDB to build
with g++ 4.8.
I've also updated the comment on 'struct gdbarch_tdep_base' to fix a
typo, and the comment on the 'gdbarch_tdep' function, to mention that
in maintainer mode a run-time type check is performed.
Diffstat (limited to 'gdb/xtensa-tdep.h')
| -rw-r--r-- | gdb/xtensa-tdep.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/xtensa-tdep.h b/gdb/xtensa-tdep.h index 1840ef98b49..da7a7080afd 100644 --- a/gdb/xtensa-tdep.h +++ b/gdb/xtensa-tdep.h @@ -167,7 +167,7 @@ struct ctype_cache /* Xtensa-specific target dependencies. */ -struct xtensa_gdbarch_tdep : gdbarch_tdep +struct xtensa_gdbarch_tdep : gdbarch_tdep_base { xtensa_gdbarch_tdep (xtensa_register_t *regmap) : regmap (regmap) |