diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2020-03-12 14:12:36 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2020-03-12 14:17:57 -0400 |
| commit | 4d696a5c686730d75623d7e41805e42ce5fcc60c (patch) | |
| tree | 077ef2a22bca4befd6b2f9088b80c7b49f703e7f /gdbserver/configure | |
| parent | 8dd8e1c7228d5dd57b3b36379718c806017988e1 (diff) | |
| download | binutils-gdb-4d696a5c686730d75623d7e41805e42ce5fcc60c.tar.gz | |
gdb/selftest.m4: ensure $development is set
Before commit 3d1e5a43cbe ("gdbsupport/configure.ac: source
development.sh"), the GDB build in non-development mode (turn
development to false in bfd/development.sh if you want to try) was
broken because the gdbsupport configure script didn't source
bfd/development.sh to set the development variable.
Since the GDB_AC_SELFTEST macro relies on the `development` variable, I
propose to modify it such that it errors out if $development does not
have an expected value of "true" or "false". This could prevent a
future similar problem from happening while refactoring the configure
scripts. It would have caught the problem fixed by the patch mentioned
earlier.
gdb/ChangeLog:
* selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
not "true" or "false".
* configure: Re-generate.
gdbserver/ChangeLog:
* configure: Re-generate.
gdbsupport/ChangeLog:
* configure: Re-generate.
Diffstat (limited to 'gdbserver/configure')
| -rwxr-xr-x | gdbserver/configure | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdbserver/configure b/gdbserver/configure index 13ac7188454..b0a25688c75 100755 --- a/gdbserver/configure +++ b/gdbserver/configure @@ -6083,6 +6083,11 @@ fi # The default value of this option changes depending whether we're on # development mode (in which case it's "true") or not (in which case # it's "false"). + +if test "x$development" != xtrue && test "x$development" != xfalse; then : + as_fn_error $? "Invalid value for \$development, got \"$development\", expecting \"true\" or \"false\"." "$LINENO" 5 +fi + # Check whether --enable-unit-tests was given. if test "${enable_unit_tests+set}" = set; then : enableval=$enable_unit_tests; case "${enableval}" in |